Kate / DTRA-178 / Enable Asians contract from SmartTrader #9050
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov Report
@@ Coverage Diff @@
## master #9050 +/- ##
======================================
Coverage 0.05% 0.05%
======================================
Files 117 117
Lines 3425 3425
Branches 893 893
======================================
Hits 2 2
Misses 3423 3423 |
packages/trader/src/App/Components/Elements/ContractAudit/contract-details.jsx
Outdated
Show resolved
Hide resolved
maryia-deriv
previously approved these changes
Aug 14, 2023
henry-deriv
approved these changes
Aug 15, 2023
maryia-deriv
approved these changes
Aug 16, 2023
maryia-deriv
previously approved these changes
Aug 16, 2023
akmal-deriv
approved these changes
Aug 17, 2023
|
Kudos, SonarCloud Quality Gate passed!
|
maryia-deriv
approved these changes
Sep 26, 2023
vinu-deriv
pushed a commit
that referenced
this pull request
Oct 10, 2023
* refactor: move trade type from un to supported * feat: ad contract type check func and add to contract details * feat: add chart markers settings for contract type * chore: add style for mobile * chore: remove gradient * chore: empty commit * chore: add gradient for contract details card for desktop * feat: add chart markers setings and update style * refactor: apply suggestions * chore: empty commit * feat: enable smart trader contract * refactor: remove rounding for barrier value * refactor: add swipble component for contract audit mobile and fix style * refactor: applied suggestions from review * feat: enable asians contract * feat: add barrier for asians contract in contract audit * refactor: update tests * refactor: checks in contract details file * chore: impove reg exp * chore: add reg ex improvement * fix: change trade type icons * fix: add entry tick * chore: empty commit * chore: empty commit * fix: conflicts * chore: remove unnessesary prop
vinu-deriv
pushed a commit
that referenced
this pull request
Oct 10, 2023
* refactor: move trade type from un to supported * feat: ad contract type check func and add to contract details * feat: add chart markers settings for contract type * chore: add style for mobile * chore: remove gradient * chore: empty commit * chore: add gradient for contract details card for desktop * feat: add chart markers setings and update style * refactor: apply suggestions * chore: empty commit * feat: enable smart trader contract * refactor: remove rounding for barrier value * refactor: add swipble component for contract audit mobile and fix style * refactor: applied suggestions from review * feat: enable asians contract * feat: add barrier for asians contract in contract audit * refactor: update tests * refactor: checks in contract details file * chore: impove reg exp * chore: add reg ex improvement * fix: change trade type icons * fix: add entry tick * chore: empty commit * chore: empty commit * fix: conflicts * chore: remove unnessesary prop
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
Screenshots:
Please provide some screenshots of the change.