Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add withdraw request verification #9085

Conversation

hamid-deriv
Copy link
Contributor

Changes:

Please provide a summary of the change.

Screenshots:

Please provide some screenshots of the change.

@vercel
Copy link

vercel bot commented Jun 21, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
deriv-app ❌ Failed (Inspect) Jun 23, 2023 2:30pm

@codecov
Copy link

codecov bot commented Jun 21, 2023

Codecov Report

Merging #9085 (63051cc) into feature/wallets_with_traders_hub (a389728) will not change coverage.
The diff coverage is 0.00%.

❗ Current head 63051cc differs from pull request most recent head 960d09d. Consider uploading reports for the commit 960d09d to get more accurate results

@@                       Coverage Diff                        @@
##           feature/wallets_with_traders_hub   #9085   +/-   ##
================================================================
  Coverage                              0.05%   0.05%           
================================================================
  Files                                   117     117           
  Lines                                  3425    3425           
  Branches                                893     893           
================================================================
  Hits                                      2       2           
  Misses                                 3423    3423           
Impacted Files Coverage Δ
...ion-empty-state/email-verification-empty-state.tsx 0.00% <0.00%> (ø)
...ty-state/email-verification-resend-empty-state.tsx 0.00% <ø> (ø)
...cashier/src/components/empty-state/empty-state.tsx 0.00% <0.00%> (ø)
...tainers/routes/error-component/error-component.tsx 0.00% <ø> (ø)
...rification-email/withdrawal-verification-email.tsx 0.00% <0.00%> (ø)
packages/cashier/src/stores/general-store.ts 0.00% <0.00%> (ø)

... and 1 file with indirect coverage changes

@github-actions
Copy link
Contributor

github-actions bot commented Jun 23, 2023

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/binary-com/deriv-app/pull/9085](https://github.com/binary-com/deriv-app/pull/9085)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-hamid-deriv-hamid-wall-321withdraw-re-f00f63.binary.sx?qa_server=red.binaryws.com&app_id=32763
    - **Original**: https://deriv-app-git-fork-hamid-deriv-hamid-wall-321withdraw-re-f00f63.binary.sx
- **App ID**: `32763`

@github-actions
Copy link
Contributor

github-actions bot commented Jun 23, 2023

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 19
🟧 Accessibility 75
🟢 Best practices 92
🟧 SEO 85
🟢 PWA 90

Lighthouse ran with https://deriv-app-git-fork-hamid-deriv-hamid-wall-321withdraw-re-f00f63.binary.sx/

@hamid-deriv hamid-deriv marked this pull request as ready for review June 23, 2023 08:27
Comment on lines +7 to +8
request_email_icon='IcWithdrawRequestVerification'
sent_email_icon='IcWithdrawRequestVerificationSent'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't need different icons for wallets and cashier. The plan is to update cashier with the icons from wallet design later when wallet changes are released.

@github-actions
Copy link
Contributor

Generating Lighthouse report...

@sonarcloud
Copy link

sonarcloud bot commented Jun 23, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

No Coverage information No Coverage information
23.4% 23.4% Duplication

Copy link
Contributor

@farzin-deriv farzin-deriv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hamid-deriv All good, Just the change Nijil mentioned 🙇🏻

@hamid-deriv
Copy link
Contributor Author

Move to this 9125.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants