-
Notifications
You must be signed in to change notification settings - Fork 299
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add withdraw request verification #9085
feat: add withdraw request verification #9085
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov Report
@@ Coverage Diff @@
## feature/wallets_with_traders_hub #9085 +/- ##
================================================================
Coverage 0.05% 0.05%
================================================================
Files 117 117
Lines 3425 3425
Branches 893 893
================================================================
Hits 2 2
Misses 3423 3423
|
…ALL-321/withdraw-request-verification-wallet
A production App ID was automatically generated for this PR. (log)
Click here to copy & paste above information.
|
🚨 Lighthouse report for the changes in this PR:
Lighthouse ran with https://deriv-app-git-fork-hamid-deriv-hamid-wall-321withdraw-re-f00f63.binary.sx/ |
request_email_icon='IcWithdrawRequestVerification' | ||
sent_email_icon='IcWithdrawRequestVerificationSent' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't need different icons for wallets and cashier. The plan is to update cashier with the icons from wallet design later when wallet changes are released.
…ithdraw-request-verification-wallet
⏳ Generating Lighthouse report... |
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@hamid-deriv All good, Just the change Nijil mentioned 🙇🏻
Move to this 9125. |
Changes:
Please provide a summary of the change.
Screenshots:
Please provide some screenshots of the change.