WEBREL-602 - Invalid success message for swap-free account #9112
Conversation
This reverts commit f0cf7f5.
…/93860/add-derivez-to-tradershub
…shontzu-deriv/deriv-app into shontzu/93860/add-derivez-to-tradershub
- Description Text below the Deriv EZ header on Onboarding page is different from Design - Text format is incorrect in DerivEZ Account creation success modal - Multiple discrepancies in Trade modal (fixed in round-up-patch 1)
- use <React.Fragment> instead ov <>
- remove unintentional {' '} whitespaces
…fference-on-Deriv-X-CFDs-font Shontzu/webrel 613/minor difference on deriv x cfds font
|
| GitGuardian id | Secret | Commit | Filename | |
|---|---|---|---|---|
| - | Generic High Entropy Secret | f911cd2 | packages/account/src/Components/currency-selector/tests/currency-selector.spec.tsx | View secret |
| - | Generic High Entropy Secret | f911cd2 | packages/account/src/Components/currency-selector/tests/currency-selector.spec.tsx | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secrets safely. Learn here the best practices.
- Revoke and rotate these secrets.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
Our GitHub checks need improvements? Share your feedbacks!
…-for-swap-free-account
| @@ -76,7 +76,7 @@ export const getMtCompanies = (is_eu: boolean) => { | |||
| const all_config = { | |||
| account_type: '', | |||
| leverage: 100, | |||
| short_title: localize('Demo'), | |||
| short_title: localize('Swap-Free'), | |||
There was a problem hiding this comment.
This configurations needs to change. it will affect all of our accounts with all type.
Your fix is temporary and needs to be changes later.
There was a problem hiding this comment.
I agree, but these changes look like it affects many other places.
There was a problem hiding this comment.
acked on this, will look into other solutions
…-for-swap-free-account
…-for-swap-free-account
|
Kudos, SonarCloud Quality Gate passed!
|
Changes:
WEBREL-602 - Invalid success message for swap-free account
Screenshots: