Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ako/ fix coverage reporter #9129

Conversation

ali-hosseini-deriv
Copy link
Member

Changes:

Please provide a summary of the change.

Screenshots:

Please provide some screenshots of the change.

@vercel
Copy link

vercel bot commented Jun 26, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 27, 2023 6:10am

@codecov
Copy link

codecov bot commented Jun 26, 2023

Codecov Report

Merging #9129 (b214835) into master (d5c38a0) will increase coverage by 17.63%.
The diff coverage is n/a.

❗ Current head b214835 differs from pull request most recent head ad42298. Consider uploading reports for the commit ad42298 to get more accurate results

@@             Coverage Diff             @@
##           master    #9129       +/-   ##
===========================================
+ Coverage    0.05%   17.69%   +17.63%     
===========================================
  Files         117     2064     +1947     
  Lines        3425    48451    +45026     
  Branches      893     8310     +7417     
===========================================
+ Hits            2     8572     +8570     
- Misses       3423    38942    +35519     
- Partials        0      937      +937     

see 2055 files with indirect coverage changes

@github-actions
Copy link
Contributor

github-actions bot commented Jun 26, 2023

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/binary-com/deriv-app/pull/9129](https://github.com/binary-com/deriv-app/pull/9129)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-ali-hosseini-deriv-ako-fix-coverage-reporter.binary.sx?qa_server=red.binaryws.com&app_id=24071
    - **Original**: https://deriv-app-git-fork-ali-hosseini-deriv-ako-fix-coverage-reporter.binary.sx
- **App ID**: `24071`

@github-actions
Copy link
Contributor

github-actions bot commented Jun 26, 2023

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 20
🟧 Accessibility 75
🟢 Best practices 92
🟧 SEO 85
🟢 PWA 90

Lighthouse ran with https://deriv-app-git-fork-ali-hosseini-deriv-ako-fix-coverage-reporter.binary.sx/

package.json Outdated Show resolved Hide resolved
@ali-hosseini-deriv ali-hosseini-deriv merged commit 6741ee5 into binary-com:master Jun 27, 2023
2 checks passed
@sonarcloud
Copy link

sonarcloud bot commented Jun 27, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
7.4% 7.4% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants