george / wall 1074 / ts type error fixes in cashier package
#9157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… TS-type-error-fixes-in-`cashier`-package-wall-1074
… TS-type-error-fixes-in-`cashier`-package-wall-1074
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
…github.com:heorhi-deriv/deriv-app into TS-type-error-fixes-in-`cashier`-package-wall-1074
|
A production App ID was automatically generated for this PR. (log)
Click here to copy & paste above information. |
|
🚨 Lighthouse report for the changes in this PR:
Lighthouse ran with https://deriv-app-git-fork-heorhi-deriv-ts-type-error-fixes-in-c-9de59e.binary.sx/ |
heorhi-deriv
commented
Jun 27, 2023
Comment on lines
-25
to
-34
| if (route.component === Redirect) { | ||
| let to = route.to; | ||
|
|
||
| // This if clause has been added just to remove '/index' from url in localhost env. | ||
| if (route.path === routes.index) { | ||
| const { location } = props; | ||
| to = location.pathname.toLowerCase().replace(route.path, ''); | ||
| } | ||
| result = <Redirect to={to} />; | ||
| } else if (route.is_authenticated && !route.is_logging_in && !route.is_logged_in) { |
There was a problem hiding this comment.
removed this part. seems like route.component can't be Redirect component. pls correct me if i'm wrong
farzin-deriv
previously approved these changes
Jun 28, 2023
Comment on lines
+43
to
+44
| export const isServerError = (error: unknown): error is TServerError => | ||
| typeof error === 'object' && error !== null && 'code' in error; |
…S-type-error-fixes-in-`cashier`-package-wall-1074
heorhi-deriv
force-pushed
the
TS-type-error-fixes-in-`cashier`-package-wall-1074
branch
from
0879408
to
a114d80
Compare
nijil-deriv
previously approved these changes
Jul 3, 2023
|
⏳ Generating Lighthouse report... |
|
Kudos, SonarCloud Quality Gate passed!
|
|
This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 5 days. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
Please provide a summary of the change.
Screenshots:
Please provide some screenshots of the change.