Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sergei / wall - 1140 / Limited functionality in Trader's Hub for "in_progress" & "migrated" #9159

Conversation

sergei-deriv
Copy link
Contributor

@sergei-deriv sergei-deriv commented Jun 27, 2023

Changes:

  • Create hook useWalletMigration
  • Create modal for case when wallet migration is in progress
  • Add as_disabled props for Button

Screenshots:

Please provide some screenshots of the change.

@vercel
Copy link

vercel bot commented Jun 27, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 2, 2023 0:42am

@codecov
Copy link

codecov bot commented Jun 27, 2023

Codecov Report

Merging #9159 (ca886e1) into feature/wallets_with_traders_hub (6262b03) will decrease coverage by 19.60%.
Report is 346 commits behind head on feature/wallets_with_traders_hub.
The diff coverage is n/a.

❗ Current head ca886e1 differs from pull request most recent head 2b1b84a. Consider uploading reports for the commit 2b1b84a to get more accurate results

@@                         Coverage Diff                          @@
##           feature/wallets_with_traders_hub   #9159       +/-   ##
====================================================================
- Coverage                             19.65%   0.05%   -19.60%     
====================================================================
  Files                                  1812     117     -1695     
  Lines                                 41040    3425    -37615     
  Branches                               8142     893     -7249     
====================================================================
- Hits                                   8067       2     -8065     
+ Misses                                32157    3423    -28734     
+ Partials                                816       0      -816     

see 1793 files with indirect coverage changes

@github-actions
Copy link
Contributor

github-actions bot commented Jun 27, 2023

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/binary-com/deriv-app/pull/9159](https://github.com/binary-com/deriv-app/pull/9159)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-sergei-deriv-sergei-wall-1140limited-f1043f.binary.sx?qa_server=red.binaryws.com&app_id=24059
    - **Original**: https://deriv-app-git-fork-sergei-deriv-sergei-wall-1140limited-f1043f.binary.sx
- **App ID**: `24059`

@github-actions
Copy link
Contributor

github-actions bot commented Jun 27, 2023

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 19
🟧 Accessibility 75
🟢 Best practices 92
🟧 SEO 85
🟢 PWA 90

Lighthouse ran with https://deriv-app-git-fork-sergei-deriv-sergei-wall-1140limited-f1043f.binary.sx/

@sergei-deriv sergei-deriv marked this pull request as ready for review July 3, 2023 05:37
@github-actions
Copy link
Contributor

github-actions bot commented Jul 10, 2023

Generating Lighthouse report...

@thisyahlen-deriv thisyahlen-deriv force-pushed the sergei/wall-1140/limited-functionality-wallets branch from 3a1cdc3 to 750d065 Compare July 26, 2023 01:36
…com/deriv-app into sergei/wall-1140/limited-functionality-wallets
…ub' into sergei/wall-1140/limited-functionality-wallets
…ub.com:sergei-deriv/deriv-app into sergei/wall-1140/limited-functionality-wallets
@sonarcloud
Copy link

sonarcloud bot commented Aug 2, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@nijil-deriv nijil-deriv changed the base branch from feature/wallets_with_traders_hub to feature/wallets_with_traders_hub_2 August 8, 2023 09:43
@nijil-deriv nijil-deriv merged commit dcb8b8f into binary-com:feature/wallets_with_traders_hub_2 Aug 8, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants