Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added recipe for prank multiple sequence aligner #1453

Merged
merged 5 commits into from
May 4, 2016
Merged

added recipe for prank multiple sequence aligner #1453

merged 5 commits into from
May 4, 2016

Conversation

odoublewen
Copy link
Contributor

  • I have read the guidelines above.
  • This PR adds a new recipe.
  • This PR updates an existing recipe.
  • This PR does something else (explain below).

fn: prank.source.150803.tgz
url: http://wasabiapp.org/download/prank/prank.source.150803.tgz
requirements:
build:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please add gcc/llvm as dependencies.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, done, thanks.

- gcc # [not osx]
- llvm # [osx]
run:
- libgcc # [not osx]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is libgcc really needed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, probably not. Removed.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This recipe should be ready to package now. Thanks!

@odoublewen
Copy link
Contributor Author

Actually, I think libgcc is a runtime requirement. The Travis CI failed without it. I added it back in and it should pass now.

I read in this ContinuumIO thread: If the recipe requires gcc to build, then you must list libgcc as run dependency.

@bgruening
Copy link
Member

@odoublewen thanks a lot!
Let us know if you want to join this community here and see #1

@bgruening bgruening merged commit 76d75aa into bioconda:master May 4, 2016
@odoublewen
Copy link
Contributor Author

@bgruening Thank you -- yes I would be happy to help contribute. I have a couple more recipes I see I can help with. I will add my name to the thread you referenced. Thanks again.

@bgruening
Copy link
Member

@odoublewen thanks a lot! I have added you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants