Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: void error on type of a function declaration #309

Merged
merged 2 commits into from
Sep 17, 2023
Merged

fix: void error on type of a function declaration #309

merged 2 commits into from
Sep 17, 2023

Conversation

b4s36t4
Copy link
Contributor

@b4s36t4 b4s36t4 commented Sep 16, 2023 •
edited by Conaclos
Loading

Summary

Solves issue with raising error on function type.

Fix #294

Test Plan

Added a new test case in valid.ts to verify the functionality is working fine.

@github-actions github-actions bot added A-Linter Area: linter A-Website Area: website L-JavaScript Language: JavaScript and super languages A-Changelog Area: changelog labels Sep 16, 2023
@Conaclos Conaclos force-pushed the fix/void-error-on-function-type branch from fd34bf1 to 3c596f8 Compare September 17, 2023 12:56
@Conaclos Conaclos self-requested a review September 17, 2023 12:59
Conaclos
Conaclos approved these changes Sep 17, 2023
View reviewed changes
Copy link
Member

@Conaclos Conaclos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@b4s36t4
Copy link
Contributor Author

b4s36t4 commented Sep 17, 2023

Thanks ❤. My first PR 😁

@Conaclos Conaclos merged commit 37e91e7 into biomejs:main Sep 17, 2023
12 of 14 checks passed
@Conaclos
Copy link
Member

A concise and perfect fix :)

@atheck
Copy link

atheck commented Sep 17, 2023 •
edited
Loading

Thank you!

@b4s36t4 b4s36t4 deleted the fix/void-error-on-function-type branch September 17, 2023 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Conaclos Conaclos Conaclos approved these changes

Assignees
No one assigned
Labels
A-Changelog Area: changelog A-Linter Area: linter A-Website Area: website L-JavaScript Language: JavaScript and super languages
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🐛 noConfusingVoidType flags function type returning void as error
3 participants
@b4s36t4 @Conaclos @atheck