Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reimplement CURIE prefix reconciliation for prescriptive contexts #975

Merged
merged 1 commit into from
Nov 2, 2023

Conversation

cthoyt
Copy link
Member

@cthoyt cthoyt commented Nov 2, 2023

This now uses the curies.remap_curie_prefixes functionality, which is better tested and more flexible.

This now uses the `curies.remap_curie_prefixes` functionality, which is better tested and more flexible.
@cthoyt cthoyt changed the title Reimplement CURIE prefix reconciliation Reimplement CURIE prefix reconciliation for prescriptive contexts Nov 2, 2023
@cthoyt
Copy link
Member Author

cthoyt commented Nov 2, 2023

cc @matentzn this PR slightly changes the OBO EPM to retain the previous prefix during reconciliation, but this shouldn't have any effect other than to enable better standardization

Copy link

codecov bot commented Nov 2, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Files Coverage Δ
src/bioregistry/record_accumulator.py 91.51% <100.00%> (+0.10%) ⬆️

... and 1 file with indirect coverage changes

📢 Thoughts on this report? Let us know!.

@cthoyt cthoyt merged commit 0c4ff72 into main Nov 2, 2023
13 checks passed
@cthoyt cthoyt deleted the reimplement-remap branch November 2, 2023 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant