Skip to content

Commit

Permalink
fix: Set "show hidden files" button value before connecting it to its…
Browse files Browse the repository at this point in the history
… slot

The problem was that the value/state of the button "Show hidden files" was set after it was connected to its slot. This triggered some other events in the main window that couldn't be processed correct because that main window itself was not finished with its construction yet.
Solution: Set the value of that button first and then connect it to its slot.

Fix:(#1536
  • Loading branch information
buhtz committed Sep 18, 2023
1 parent ddd142b commit 37018e0
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion CHANGES
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
Back In Time

Version 1.4.1-dev (development of upcoming release)
* wip
* Fix bug: GUI didn't start when show hidden files button was on (#1535).

Version 1.4.0 (2023-09-14)
* Project: Renamed branch "master" to "main" and started "gitflow" branching model.
Expand Down
2 changes: 1 addition & 1 deletion qt/app.py
Original file line number Diff line number Diff line change
Expand Up @@ -596,9 +596,9 @@ def _create_actions(self):
self.act_pause_take_snapshot.setVisible(False)
self.act_resume_take_snapshot.setVisible(False)
self.act_stop_take_snapshot.setVisible(False)
self.act_show_hidden.toggled.connect(self.btnShowHiddenFilesToggled)
self.act_show_hidden.setCheckable(True)
self.act_show_hidden.setChecked(self.showHiddenFiles)
self.act_show_hidden.toggled.connect(self.btnShowHiddenFilesToggled)

def _create_shortcuts_without_actions(self):
"""Create shortcuts that are not related to a visual element in the
Expand Down

0 comments on commit 37018e0

Please sign in to comment.