Skip to content

Commit

Permalink
Improve SSH button tooltips for better usability (#1369)
Browse files Browse the repository at this point in the history
* Requires new translations before the next release
* Fix a typo in "backup-job" command description

Co-authored-by: aryoda <11374410+aryoda@users.noreply.github.com>
  • Loading branch information
aryoda and aryoda committed Nov 20, 2022
1 parent 0f3eeef commit 713590f
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 3 deletions.
2 changes: 1 addition & 1 deletion common/backintime.py
Original file line number Diff line number Diff line change
Expand Up @@ -239,7 +239,7 @@ def createParsers(app_name = 'backintime'):
aliases.append((command, nargs))
description = 'Take a new snapshot in background only ' +\
'if the profile is scheduled and the machine ' +\
'is not on battery. This is use by cron jobs.'
'is not on battery. This is used by cron jobs.'
backupJobCP = subparsers.add_parser(command,
parents = [rsyncArgsParser],
epilog = epilogCommon,
Expand Down
5 changes: 3 additions & 2 deletions qt/settingsdialog.py
Original file line number Diff line number Diff line change
Expand Up @@ -245,7 +245,7 @@ def __init__(self, parent):
self.btnSshPrivateKeyFile = QToolButton(self)
self.btnSshPrivateKeyFile.setToolButtonStyle(Qt.ToolButtonIconOnly)
self.btnSshPrivateKeyFile.setIcon(icon.FOLDER)
self.btnSshPrivateKeyFile.setToolTip(_('Key File'))
self.btnSshPrivateKeyFile.setToolTip(_('Choose an existing private key file (normally named "id_rsa")'))
self.btnSshPrivateKeyFile.setMinimumSize(32, 28)
hlayout3.addWidget(self.btnSshPrivateKeyFile)
self.btnSshPrivateKeyFile.clicked \
Expand All @@ -255,10 +255,11 @@ def __init__(self, parent):
self.btnSshKeyGen.setToolButtonStyle(Qt.ToolButtonIconOnly)
self.btnSshKeyGen.setIcon(icon.ADD)
self.btnSshKeyGen.setToolTip(
_('Create a new SSH key without Password.'))
_('Create a new SSH key without password (not allowed if a private key file is already selected)'))
self.btnSshKeyGen.setMinimumSize(32, 28)
hlayout3.addWidget(self.btnSshKeyGen)
self.btnSshKeyGen.clicked.connect(self.btnSshKeyGenClicked)
# Disable SSH key generation button if a key file is already set
self.txtSshPrivateKeyFile.textChanged \
.connect(lambda x: self.btnSshKeyGen.setEnabled(not x))

Expand Down

0 comments on commit 713590f

Please sign in to comment.