Improve logging for canBackup check (#1142 #1143 #1328)

Do not automatically log an error if the target drive is not accessible, as we might simply be waiting for it to come online. In turn, add a debug message to the 30s wait loop.

CHANGES

@@ -7,6 +7,7 @@ Upcoming Release
 * Desktop integration: update .desktop file to mark Back In Time as a single main window program (#1258)
 * Bugfix: AttributeError in "Diff Options" dialog (#898)
 * Bugfix: Settings GUI: "Save password to Keyring" was disabled due to "no appropriate keyring found" (#1321)
+* Bugfix: Avoid logging errors while waiting for a target drive to be mounted (#1142, #1143, #1328)
 * Documentation update: correct description of profile<N>.schedule.time in backintime-config manpage (#1270)
 * Translation update: Brazilian Portuguese (#1267)
 * Translation update: Italian (#1110, #1123)

common/config.py

@@ -1376,10 +1376,14 @@ def canBackup(self, profile_id = None):
         if not self.isConfigured(profile_id):
             return False
 
-        if not os.path.isdir(self.snapshotsFullPath(profile_id)):
-            logger.error("%s does not exist"
-                         %self.snapshotsFullPath(profile_id),
-                         self)
+        path = self.snapshotsFullPath(profile_id)
+
+        if not os.path.exists(path):
+            return False
+
+        if not os.path.isdir(path):
+            # path exists, but is no dir: something's very wrong.
+            logger.error("%s is not a directory"%path, self)
             return False
 
         return True

common/snapshots.py

@@ -677,6 +677,7 @@ def backup(self, force = False):
                                     gettext.ngettext('Waiting %s second.', 'Waiting %s seconds.', 30) % 30,
                                     30)
                         for counter in range(30, 0, -1):
+                            logger.info("Cannot start snapshot yet: target directory not accessible. Waiting 1s.")
                             time.sleep(1)
                             if self.config.canBackup():
                                 break