-
Notifications
You must be signed in to change notification settings - Fork 201
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #1592, #1580, #836, #1350: "qt5_probing.py" hangs; Cannot launch … BiT (root) on Wayland #1597
Conversation
…run as root and no user is logged into a desktop environment
…robing.py" hangs; Cannot launch BiT (root) on Wayland - "qt5_probing.py" hangs when BiT is run as root and no user is logged into a desktop environment - BiT (root) starter script does not set Qt5 wayland-egl plugin anymore but uses the default (like BiT userland) - Improve logging (all sub process do now use the log context "backintime" too for easy journalctl grepping
…robing.py" hangs; Cannot launch BiT (root) on Wayland - "qt5_probing.py" hangs when BiT is run as root and no user is logged into a desktop environment - BiT (root) starter script does not set Qt5 wayland-egl plugin anymore but uses the default (like BiT userland) - Improve logging (all sub processes do now use the log context "backintime" too for easy journalctl grepping
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems OK to me with my limited understanding of the original problem.
common/logger.py
Outdated
""" | ||
Initializes the logger | ||
|
||
Esp. sets the app name for the log output so that the system log | ||
can be queried with with grep. | ||
|
||
Don't forget to call it in each sub process that uses logging. | ||
""" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would like to rephrase that docstring somehow to make clear which log system is used and that it is not the regular logging module of python.
"""
Initializes the logger system using syslog.
Esp. sets the app name as identifier for the log entries in the syslog.
Attention: Call it in each sub process that uses logging.
"""
By the way. You don't need grep here. Syslog is a special case when it comes to journalctl
which usually works with unit names. You need to give it the SYSLOG_IDENTIFIER
we used here.
journalctl -t backintime
# or
journalctl SYSLOG_IDENTIFIER=backintime
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool side note, I didn't know that (and have never read the man pages of journalctl
completely 😉
CHANGELOG was updated