Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(lint): W0611 (unused imports) #1775

Merged
merged 6 commits into from
Aug 11, 2024

Conversation

feman323
Copy link
Contributor

@feman323 feman323 commented Jul 1, 2024

Removed the unused imports from the files config.py, encfstoos.py and passwd.py.

This reduces the number of unused imports (W0611) from 28 to 23.

Copy link
Member

@buhtz buhtz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello Manuel,
On behalf of the team, thank you for your contribution and taking
the time to improve Back In Time. We appreciate it.

Your PR looks fine. It will get merged after a cool off period. To find out how we usually tread PRs please read "What happens after you opened a Pull Request (PR)?".

Best,
Christian

@buhtz buhtz added the PR: Merge after creative-break Merge after creative-break (min. 1 week) label Jul 1, 2024
@buhtz buhtz added this to the Upcoming release (1.5.0) milestone Jul 1, 2024
@buhtz
Copy link
Member

buhtz commented Jul 1, 2024

Hello Manual,
you asked if you can add more modifications.

My stomach tells me ~10 files are OK. 25 errors are Ok. Fix them all if you want.

You don't have to create a new PR for this. Just work further on your existing branch. Commit and push. This PR will be updated automatically.

Best,
Christian

@buhtz buhtz changed the title Remove unused imports in config.py, encfstools.py and passwd.py fix(lint): W0611 (unused imports) Jul 1, 2024
@buhtz buhtz added the Feedback needs user response, may be closed after timeout without a response label Jul 3, 2024
common/doc-dev/conf.py Outdated Show resolved Hide resolved
Copy link
Member

@buhtz buhtz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. Just added some minor suggestions and modifications.

common/doc-dev/conf.py Outdated Show resolved Hide resolved
common/qt_probing.py Show resolved Hide resolved
@buhtz buhtz added PR: Modifications requested Maintenance team requested modifications and waiting for their implementation and removed PR: Merge after creative-break Merge after creative-break (min. 1 week) labels Jul 3, 2024
@buhtz
Copy link
Member

buhtz commented Jul 4, 2024

Hello Manuel,
we plan to release a new BIT version (might be 1.5.0) in the end of July to make it hit the upcoming release of Ubuntu 24.10 (Oracular Oriole) in October this year. Ubuntus Debian Import Freeze is at August 15th. So it is an important release.

To my understanding, knowledge and experience I see no real problem or real risk with cleaning up the unused imports. But it is also my experience that I am often wrong with assumptions like this. 😆 Because of that I would like to put your PR on hold until the upcoming release is out and merge it after that.

Best,
Christian

@feman323
Copy link
Contributor Author

feman323 commented Jul 4, 2024

Hello Manuel, we plan to release a new BIT version (might be 1.5.0) in the end of July to make it hit the upcoming release of Ubuntu 24.10 (Oracular Oriole) in October this year. Ubuntus Debian Import Freeze is at August 15th. So it is an important release.

To my understanding, knowledge and experience I see no real problem or real risk with cleaning up the unused imports. But it is also my experience that I am often wrong with assumptions like this. 😆 Because of that I would like to put your PR on hold until the upcoming release is out and merge it after that.

Best, Christian

Hi Christian,

sure I totally understand that. This is not just your experience 😁

Regards,

Manuel

common/qt_probing.py Show resolved Hide resolved
@buhtz buhtz added PR: Merge after creative-break Merge after creative-break (min. 1 week) and removed Feedback needs user response, may be closed after timeout without a response PR: Modifications requested Maintenance team requested modifications and waiting for their implementation labels Jul 18, 2024
@buhtz buhtz merged commit 61550f7 into bit-team:dev Aug 11, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: Merge after creative-break Merge after creative-break (min. 1 week)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants