Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bitnami/thanos] added pvc labels to thanos-receive #24934

Merged
merged 6 commits into from
Apr 23, 2024

Conversation

thorker
Copy link
Contributor

@thorker thorker commented Apr 5, 2024

Description of the change

Benefits

  • labels can be added to the thanos-receive pvc's

Possible drawbacks

Applicable issues

Additional information

Checklist

  • Chart version bumped in Chart.yaml according to semver. This is not necessary when the changes only affect README.md files.
  • Variables are documented in the values.yaml and added to the README.md using readme-generator-for-helm
  • Title of the pull request follows this pattern [bitnami/<name_of_the_chart>] Descriptive title
  • All commits signed off and in agreement of Developer Certificate of Origin (DCO)

@github-actions github-actions bot added thanos triage Triage is needed labels Apr 5, 2024
@github-actions github-actions bot requested a review from carrodher April 5, 2024 09:15
@carrodher
Copy link
Member

Thank you for initiating this pull request. We appreciate your effort. Just a friendly reminder that it's important to sign your commits. Adding your signature certifies that you either authored the patch or have the necessary rights to contribute the changes. You can find detailed information on how to do this in the “Sign your work” section of our contributing guidelines.

Feel free to reach out if you have any questions or need assistance with the signing process.

bitnami-bot and others added 2 commits April 5, 2024 12:44
* [bitnami/argo-cd] Release 6.0.5 updating components versions

Signed-off-by: Bitnami Containers <bitnami-bot@vmware.com>

* Update CRDs automatically

Signed-off-by: Bitnami Containers <bitnami-bot@vmware.com>

---------

Signed-off-by: Bitnami Containers <bitnami-bot@vmware.com>
Signed-off-by: Thorsten Kerber <th.kerber+github@gmail.com>
Signed-off-by: Thorsten Kerber <th.kerber+github@gmail.com>
thorker and others added 2 commits April 16, 2024 10:54
Signed-off-by: thorker <46462404+thorker@users.noreply.github.com>
Signed-off-by: Thorsten Kerber <th.kerber+github@gmail.com>
@thorker
Copy link
Contributor Author

thorker commented Apr 16, 2024

@carrodher Can you please review my suggestions?

@javsalgar javsalgar added verify Execute verification workflow for these changes in-progress labels Apr 18, 2024
@github-actions github-actions bot removed the triage Triage is needed label Apr 18, 2024
@github-actions github-actions bot removed the request for review from carrodher April 18, 2024 10:17
dgomezleon
dgomezleon previously approved these changes Apr 22, 2024
Copy link
Member

@dgomezleon dgomezleon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: David Gomez <dgomezleon@vmware.com>
Signed-off-by: David Gomez <dgomezleon@vmware.com>
@dgomezleon dgomezleon merged commit 2acf132 into bitnami:main Apr 23, 2024
8 checks passed
matheusmgon pushed a commit to matheusmgon/charts that referenced this pull request May 2, 2024
* [bitnami/argo-cd] Release 6.0.5 (bitnami#24927)

* [bitnami/argo-cd] Release 6.0.5 updating components versions

Signed-off-by: Bitnami Containers <bitnami-bot@vmware.com>

* Update CRDs automatically

Signed-off-by: Bitnami Containers <bitnami-bot@vmware.com>

---------

Signed-off-by: Bitnami Containers <bitnami-bot@vmware.com>
Signed-off-by: Thorsten Kerber <th.kerber+github@gmail.com>

* feat: added pvc labels to receiver

Signed-off-by: Thorsten Kerber <th.kerber+github@gmail.com>

* chore: bumped Chart
Signed-off-by: Thorsten Kerber <th.kerber+github@gmail.com>

---------

Signed-off-by: Bitnami Containers <bitnami-bot@vmware.com>
Signed-off-by: Thorsten Kerber <th.kerber+github@gmail.com>
Signed-off-by: thorker <46462404+thorker@users.noreply.github.com>
Signed-off-by: David Gomez <dgomezleon@vmware.com>
Co-authored-by: Bitnami Bot <bitnami-bot@vmware.com>
Co-authored-by: David Gomez <dgomezleon@vmware.com>
Signed-off-by: Matheus Goncalves <matheus.goncalves@bexio.com>
matheusmgon pushed a commit to matheusmgon/charts that referenced this pull request May 3, 2024
* [bitnami/argo-cd] Release 6.0.5 (bitnami#24927)

* [bitnami/argo-cd] Release 6.0.5 updating components versions

Signed-off-by: Bitnami Containers <bitnami-bot@vmware.com>

* Update CRDs automatically

Signed-off-by: Bitnami Containers <bitnami-bot@vmware.com>

---------

Signed-off-by: Bitnami Containers <bitnami-bot@vmware.com>
Signed-off-by: Thorsten Kerber <th.kerber+github@gmail.com>

* feat: added pvc labels to receiver

Signed-off-by: Thorsten Kerber <th.kerber+github@gmail.com>

* chore: bumped Chart
Signed-off-by: Thorsten Kerber <th.kerber+github@gmail.com>

---------

Signed-off-by: Bitnami Containers <bitnami-bot@vmware.com>
Signed-off-by: Thorsten Kerber <th.kerber+github@gmail.com>
Signed-off-by: thorker <46462404+thorker@users.noreply.github.com>
Signed-off-by: David Gomez <dgomezleon@vmware.com>
Co-authored-by: Bitnami Bot <bitnami-bot@vmware.com>
Co-authored-by: David Gomez <dgomezleon@vmware.com>
Signed-off-by: Matheus Goncalves <matheus.goncalves@bexio.com>
matheusmgon pushed a commit to matheusmgon/charts that referenced this pull request May 7, 2024
* [bitnami/argo-cd] Release 6.0.5 (bitnami#24927)

* [bitnami/argo-cd] Release 6.0.5 updating components versions

Signed-off-by: Bitnami Containers <bitnami-bot@vmware.com>

* Update CRDs automatically

Signed-off-by: Bitnami Containers <bitnami-bot@vmware.com>

---------

Signed-off-by: Bitnami Containers <bitnami-bot@vmware.com>
Signed-off-by: Thorsten Kerber <th.kerber+github@gmail.com>

* feat: added pvc labels to receiver

Signed-off-by: Thorsten Kerber <th.kerber+github@gmail.com>

* chore: bumped Chart
Signed-off-by: Thorsten Kerber <th.kerber+github@gmail.com>

---------

Signed-off-by: Bitnami Containers <bitnami-bot@vmware.com>
Signed-off-by: Thorsten Kerber <th.kerber+github@gmail.com>
Signed-off-by: thorker <46462404+thorker@users.noreply.github.com>
Signed-off-by: David Gomez <dgomezleon@vmware.com>
Co-authored-by: Bitnami Bot <bitnami-bot@vmware.com>
Co-authored-by: David Gomez <dgomezleon@vmware.com>
Signed-off-by: Matheus Gonçalves <mathmgoncalves@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
solved thanos verify Execute verification workflow for these changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants