Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[bitnami/keycloak] Update README.md #25996

Merged
merged 1 commit into from
May 20, 2024
Merged

[bitnami/keycloak] Update README.md #25996

merged 1 commit into from
May 20, 2024

Conversation

lucasfcnunes
Copy link
Contributor

@lucasfcnunes lucasfcnunes commented May 17, 2024 •
edited
Loading

Description of the change

  • There's no auth.managementPassword value in the templates
  • keycloakConfigCli.configuration receives an object that has keys matching *.json to work
    • keycloakConfigCli.enabled needs to be set to true
  • add a newline at EOF

Benefits

Possible drawbacks

Applicable issues

  • fixes #

Additional information

Checklist

  • Chart version bumped in Chart.yaml according to semver. This is not necessary when the changes only affect README.md files.
  • Variables are documented in the values.yaml and added to the README.md using readme-generator-for-helm
  • Title of the pull request follows this pattern [bitnami/<name_of_the_chart>] Descriptive title
  • All commits signed off and in agreement of Developer Certificate of Origin (DCO)

@github-actions github-actions bot added keycloak triage Triage is needed labels May 17, 2024
@github-actions github-actions bot requested a review from carrodher May 17, 2024 22:20
@lucasfcnunes
Update README.md
9c8037a 
Signed-off-by: Lucas Fernando Cardoso Nunes <lucasfc.nunes@gmail.com>
@lucasfcnunes lucasfcnunes marked this pull request as ready for review May 17, 2024 22:30
@github-actions github-actions bot removed the triage Triage is needed label May 18, 2024
@github-actions github-actions bot removed the request for review from carrodher May 18, 2024 16:35
@github-actions github-actions bot requested a review from rafariossaa May 18, 2024 16:35
rafariossaa
rafariossaa approved these changes May 20, 2024
View reviewed changes
Copy link
Contributor

@rafariossaa rafariossaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi,
Thanks for fixing the README.

LGTM

@rafariossaa rafariossaa merged commit d04084c into bitnami:main May 20, 2024
17 checks passed
@migruiz4 migruiz4 mentioned this pull request May 21, 2024
Closed
fmulero pushed a commit to fmulero/charts that referenced this pull request May 22, 2024
@lucasfcnunes @fmulero
Update README.md (bitnami#25996)
a9efcf9 
Signed-off-by: Lucas Fernando Cardoso Nunes <lucasfc.nunes@gmail.com>
Signed-off-by: Fran Mulero <fmulero@vmware.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rafariossaa rafariossaa rafariossaa approved these changes

Assignees

@rafariossaa rafariossaa

Labels
keycloak solved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lucasfcnunes @rafariossaa @carrodher