Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bitnami/mongodb] add emptyDir sizeLimit #28771

Closed
wants to merge 1 commit into from

Conversation

monotek
Copy link
Contributor

@monotek monotek commented Aug 8, 2024

Description of the change

add a configurable sizeLimit to the new emptDir mounts

Benefits

  • people using a policy to enforce sizelimit don't run in policyviolations anymore
  • k8s nodes filesystem protected from filling up by accident

Possible drawbacks

Applicable issues

Additional information

Checklist

  • Chart version bumped in Chart.yaml according to semver. This is not necessary when the changes only affect README.md files.
  • Variables are documented in the values.yaml and added to the README.md using readme-generator-for-helm
  • Title of the pull request follows this pattern [bitnami/<name_of_the_chart>] Descriptive title
  • All commits signed off and in agreement of Developer Certificate of Origin (DCO)

@github-actions github-actions bot added mongodb triage Triage is needed labels Aug 8, 2024
@github-actions github-actions bot requested a review from carrodher August 8, 2024 07:59
@javsalgar javsalgar changed the title [mongodb] add emptyDir sizeLimit [bitnami/mongodb] add emptyDir sizeLimit Aug 8, 2024
@javsalgar
Copy link
Contributor

Hi!

Thank you so much for the PR! It seems that you changed appVersion instead of version. Could you fix it?

Plus, I'm concerned that adding a limit that wasn't previously there could lead to a breaking change. Could you set the default value to "" and only add the section if the value is set?

@monotek monotek force-pushed the mongodb-emtpydir-sizelimit branch 2 times, most recently from d4200e5 to 737af76 Compare August 8, 2024 09:18
Signed-off-by: André Bauer <andre.bauer@staffbase.com>
Copy link

This Pull Request has been automatically marked as "stale" because it has not had recent activity (for 15 days). It will be closed if no further activity occurs. Thank you for your contribution.

@github-actions github-actions bot added the stale 15 days without activity label Aug 24, 2024
Copy link

Due to the lack of activity in the last 5 days since it was marked as "stale", we proceed to close this Pull Request. Do not hesitate to reopen it later if necessary.

@bitnami-bot bitnami-bot added stale 15 days without activity and removed stale 15 days without activity labels Aug 29, 2024
@monotek
Copy link
Contributor Author

monotek commented Sep 24, 2024

reopen

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mongodb solved stale 15 days without activity triage Triage is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bitnami/mongodb] new empty-dir volume should have configurable sizelimt
4 participants