-
Notifications
You must be signed in to change notification settings - Fork 9.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[bitnami/nginx] stream server blocks #29491
Conversation
Signed-off-by: TrueGameover <truegameover@gmail.com>
Signed-off-by: TrueGameover <truegameover@gmail.com>
Signed-off-by: Carlos Rodríguez Hernández <carlosrh@vmware.com>
Signed-off-by: Bitnami Containers <bitnami-bot@vmware.com>
Signed-off-by: Bitnami Containers <bitnami-bot@vmware.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes LGTM, just a minor suggestion
{{- if .Values.extraEnvVars }} | ||
{{- include "common.tplvalues.render" (dict "value" .Values.extraEnvVars "context" $) | nindent 12 }} | ||
{{- end }} | ||
{{- if or .Values.streamServerBlock .Values.existingStreamServerBlockConfigmap }} | ||
- name: NGINX_ENABLE_STREAM | ||
value: "true" | ||
{{- end }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
{{- if .Values.extraEnvVars }} | |
{{- include "common.tplvalues.render" (dict "value" .Values.extraEnvVars "context" $) | nindent 12 }} | |
{{- end }} | |
{{- if or .Values.streamServerBlock .Values.existingStreamServerBlockConfigmap }} | |
- name: NGINX_ENABLE_STREAM | |
value: "true" | |
{{- end }} | |
{{- if or .Values.streamServerBlock .Values.existingStreamServerBlockConfigmap }} | |
- name: NGINX_ENABLE_STREAM | |
value: "true" | |
{{- end }} | |
{{- if .Values.extraEnvVars }} | |
{{- include "common.tplvalues.render" (dict "value" .Values.extraEnvVars "context" $) | nindent 12 }} | |
{{- end }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok, I changed it
Signed-off-by: Juan José Martos <jotamartos@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please bump the version of the Chart, there was a new release in the meantime.
Note: You will need to pull your branch as I resolved a conflict in the changelog file
Signed-off-by: TrueGameover <truegameover@gmail.com>
Signed-off-by: Bitnami Containers <bitnami-bot@vmware.com>
Signed-off-by: Juan José Martos <jotamartos@gmail.com>
Signed-off-by: Bitnami Containers <bitnami-bot@vmware.com>
Description of the change
Configuration allowed for stream server blocks in nginx container.
Benefits
Can configure stream server blocks.
Possible drawbacks
no
Applicable issues
Additional information
bitnami/containers#72353
Checklist
Chart.yaml
according to semver. This is not necessary when the changes only affect README.md files.README.md
using readme-generator-for-helm