Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bitnami/rabbitmq-cluster-operator] Add PodDistruptionBidget (PBDs) #29578

Merged
merged 3 commits into from
Sep 24, 2024

Conversation

pinkavaj
Copy link
Contributor

Description of the change

Add PodDisruptionBudget (PBD) to allow run the RabbitMQ Operator in HA mode. This is useful for production, because when the messaging-topology-operator pod is eg re-scheduled the validating-webhook cannot be called and this hinders cluster usability, if running only in single pod with no PDB.

Benefits

Reduces time when the usability of the K8s cluster is reduced.

Possible drawbacks

Adds PDB even when running in single pod mode, I see no issue with this, seems this is also default for most of the present charts.

Checklist

  • Chart version bumped in Chart.yaml according to semver. This is not necessary when the changes only affect README.md files.
  • Variables are documented in the values.yaml and added to the README.md using readme-generator-for-helm
  • Title of the pull request follows this pattern [bitnami/<name_of_the_chart>] Descriptive title
  • All commits signed off and in agreement of Developer Certificate of Origin (DCO)

Allow running the Operator, and especially the validating webhook, in HA
mode.

Signed-off-by: Jiří Pinkava <j-pi@seznam.cz>
@pinkavaj pinkavaj marked this pull request as ready for review September 23, 2024 15:23
Signed-off-by: Bitnami Containers <bitnami-bot@vmware.com>
@carrodher carrodher added verify Execute verification workflow for these changes in-progress labels Sep 24, 2024
@github-actions github-actions bot removed the triage Triage is needed label Sep 24, 2024
@github-actions github-actions bot removed the request for review from javsalgar September 24, 2024 06:47
Signed-off-by: Bitnami Containers <bitnami-bot@vmware.com>
Copy link
Contributor

@juan131 juan131 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this great contribution! LGTM

@juan131 juan131 merged commit 1913960 into bitnami:main Sep 24, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rabbitmq-cluster-operator solved verify Execute verification workflow for these changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants