Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove excessive -x bash debugging flag #24

Merged
merged 1 commit into from
Feb 20, 2023
Merged

Remove excessive -x bash debugging flag #24

merged 1 commit into from
Feb 20, 2023

Conversation

arm4b
Copy link
Member

@arm4b arm4b commented Feb 18, 2023 •
edited
Loading

The bash -x is too verbose for using in production environment and while reading the GHA logs. Removing.

@arm4b arm4b added the enhancement New feature or request label Feb 18, 2023
PhillypHenning
PhillypHenning approved these changes Feb 20, 2023
View reviewed changes
Copy link
Contributor

@PhillypHenning PhillypHenning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps we should put the -x value behind a BITOPS LOGGING VERBOSITY check

@arm4b
Copy link
Member Author

arm4b commented Feb 20, 2023 •
edited
Loading

Yeah, at this moment we dont pass any verbosity ENVs to the plugins.
+1 bitovi/bitops#401 for the future ideas on how to normalize the verbosity across the core and plugins.

@arm4b arm4b merged commit 0deae23 into main Feb 20, 2023
@arm4b arm4b deleted the enh/remove-bash-debugging branch February 20, 2023 15:09
@arm4b arm4b mentioned this pull request Feb 23, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PhillypHenning PhillypHenning PhillypHenning approved these changes

@mickmcgrath13 mickmcgrath13 Awaiting requested review from mickmcgrath13

@LeoDiazL LeoDiazL Awaiting requested review from LeoDiazL

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@arm4b @PhillypHenning