Applying update to generators #30
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||||
|---|---|---|---|---|---|---|---|---|
| @@ -0,0 +1,80 @@ | ||||||||
| #!/bin/bash | ||||||||
|
|
||||||||
| set -e | ||||||||
|
|
||||||||
| GITHUB_IDENTIFIER="$(echo $($GITHUB_ACTION_PATH/operations/_scripts/generate/generate_identifier.sh) | tr '[:upper:]' '[:lower:]')" | ||||||||
|
|
||||||||
| function generateIdentifiers () { | ||||||||
| # Generate TF_STATE_BUCKET ID if empty | ||||||||
| if [ -z "${TF_STATE_BUCKET}" ]; then | ||||||||
| if [[ ${#GITHUB_IDENTIFIER} < 55 ]]; then | ||||||||
| TF_STATE_BUCKET="${GITHUB_IDENTIFIER}-tf-state" | ||||||||
| else | ||||||||
| TF_STATE_BUCKET="${GITHUB_IDENTIFIER}-tf" | ||||||||
| fi | ||||||||
| else | ||||||||
| export TF_STATE_BUCKET=${TF_STATE_BUCKET} | ||||||||
| fi | ||||||||
| # Generate LB_LOGS_BUCKET ID | ||||||||
| if [[ ${#GITHUB_IDENTIFIER} < 59 ]]; then | ||||||||
| export LB_LOGS_BUCKET="${GITHUB_IDENTIFIER}-logs" | ||||||||
| else | ||||||||
| export LB_LOGS_BUCKET="${GITHUB_IDENTIFIER}-lg" | ||||||||
| fi | ||||||||
| } | ||||||||
|
|
||||||||
| function checkBucket() { | ||||||||
|
There was a problem hiding this comment. It's nice to have a function here 👍 let's also follow the more common bash shellcheck naming standards (similar to python, lowercase with underscore separators):
Suggested change
Could we also include a line comment for this function describing briefly what it does? |
||||||||
| # check length of bucket name | ||||||||
| if [[ ${#1} -lt 3 || ${#1} -gt 63 ]]; then | ||||||||
| echo "Bucket name must be between 3 and 63 characters long." | ||||||||
| exit 1 | ||||||||
| fi | ||||||||
|
|
||||||||
| # check that bucket name consists only of lowercase letters, numbers, dots (.), and hyphens (-) | ||||||||
| if [[ ! $1 =~ ^[a-z0-9.-]+$ ]]; then | ||||||||
| echo "Bucket name can only consist of lowercase letters, numbers, dots (.), and hyphens (-)." | ||||||||
| exit 1 | ||||||||
| fi | ||||||||
|
|
||||||||
| # check that bucket name begins and ends with a letter or number | ||||||||
| if [[ ! $1 =~ ^[a-zA-Z0-9] ]]; then | ||||||||
| echo "Bucket name must begin with a letter or number." | ||||||||
| exit 1 | ||||||||
| fi | ||||||||
| if [[ ! $1 =~ [a-zA-Z0-9]$ ]]; then | ||||||||
| echo "Bucket name must end with a letter or number." | ||||||||
| exit 1 | ||||||||
| fi | ||||||||
|
|
||||||||
| # check that bucket name does not contain two adjacent periods | ||||||||
| if [[ $1 =~ \.\. ]]; then | ||||||||
| echo "Bucket name cannot contain two adjacent periods." | ||||||||
| exit 1 | ||||||||
| fi | ||||||||
|
|
||||||||
| # check that bucket name is not formatted as an IP address | ||||||||
| if [[ $1 =~ ^[0-9]{1,3}\.[0-9]{1,3}\.[0-9]{1,3}\.[0-9]{1,3}$ ]]; then | ||||||||
| echo "Bucket name cannot be formatted as an IP address." | ||||||||
| exit 1 | ||||||||
| fi | ||||||||
|
|
||||||||
| # check that bucket name does not start with the prefix xn-- | ||||||||
| if [[ $1 =~ ^xn-- ]]; then | ||||||||
| echo "Bucket name cannot start with the prefix xn--." | ||||||||
| exit 1 | ||||||||
| fi | ||||||||
|
|
||||||||
| # check that bucket name does not end with the suffix -s3alias | ||||||||
| if [[ $1 =~ -s3alias$ ]]; then | ||||||||
| echo "Bucket name cannot end with the suffix -s3alias." | ||||||||
| exit 1 | ||||||||
| fi | ||||||||
| } | ||||||||
|
|
||||||||
| generateIdentifiers | ||||||||
|
|
||||||||
| checkBucket $TF_STATE_BUCKET | ||||||||
| checkBucket $LB_LOGS_BUCKET | ||||||||
|
|
||||||||
| export TF_STATE_BUCKET=${TF_STATE_BUCKET} | ||||||||
| export LB_LOGS_BUCKET=${LB_LOGS_BUCKET} | ||||||||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same as for the other function, naming and description would be nice to haves.
And quickly looking at it, I didn't understand what kind of Identifiers the function generates.
generate_bucket_names()orgenerate_bucket_identifiersperhaps would be more clear?