Extract a block containing defer in cache_archive.go's Write loop #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The deferred executions are responsible for closing files, but will not be executed until the function returns. Therefore, so many files will remain open at the time the old implementation of Write returns, which can cause "too many files open" error. This change fixes the problem by extracting defer into another function which does not contain a loop.
Codecov Report
@@ Coverage Diff @@
## master #32 +/- ##
==========================================
+ Coverage 42.44% 42.51% +0.07%
==========================================
Files 6 6
Lines 417 421 +4
==========================================
+ Hits 177 179 +2
- Misses 213 214 +1
- Partials 27 28 +1
Continue to review full report at Codecov.
|
|
Thanks @akihikodaki, |
|
@trapacska can you please merge this? |
trapacska
approved these changes
Oct 7, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The deferred executions are responsible for closing files, but will not be executed until the function returns. Therefore, so many files will remain open at the time the old implementation of
Writereturns, which can cause "too many files open" error.This change fixes the problem by extracting defer into another function which does not contain a loop.