Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

QR Scan package no longer works #256

Closed
grctest opened this issue Jul 5, 2023 · 2 comments
Closed

QR Scan package no longer works #256

grctest opened this issue Jul 5, 2023 · 2 comments

Comments

@grctest
Copy link
Contributor

grctest commented Jul 5, 2023

Describe the bug

The QR code scanner component is no longer able to access the webcam; the package hasn't been updated in a couple years.

To Reproduce

Go to the QR code scanning page, try to scan a QR code with your webcam.

Expected behavior

QR code webcam view renders.

Desktop (please complete the following information):

  • OS: Windows 11
  • Browser: Electron client, adapter.browserDetails.browser {browser: 'chrome', version: 102}
  • Version: Develop

Additional context

Vue3 support should soon arrive to an alternative and more actively maintained package: gruhn/vue-qrcode-reader#203

Relevant github issue: scholtz/qrcode-reader-vue3#2

We should migrate to using vue-qrcode-reader when it supports vue3 (currently only supports vue2).
grctest added a commit to BTS-CM/beet that referenced this issue Jul 5, 2023
@grctest
Bug fixes & translations
6342c9d 
Fix settingsRow error
Additional error checking
Remove "Scan QR" button until issue bitshares#256 is resolved
Prevent qrTX disrupting the ipcRenderer popup creation process
Translate the permission prompt
@grctest
Copy link
Contributor Author

grctest commented Jul 5, 2023

Temporarily disabled the QR scanning component in #247

grctest added a commit to BTS-CM/beet that referenced this issue Jul 6, 2023
@grctest
Replace qrcode package
6afe935 
Replacing qrcode-reader-vue3 for vue-qrcode-reader package now that it supports vue3, resolving bitshares#256
@grctest grctest mentioned this issue Jul 6, 2023
Merged
sschiessl-bcp pushed a commit that referenced this issue Aug 29, 2023
@grctest
New upload json feature, fixes & optimizations
62330b6 
Implement new upload JSON feature to address #246

Introduced a fix for TUSC: #248

Introduces optimized account/asset lookup for all BTS operations: #249

Fix balances rendering properly: #255

Localizes the contents of BTS blockchain based injected operation prompts: #252

Resolves #256
@grctest
Copy link
Contributor Author

grctest commented Aug 29, 2023

Merged fix into develop branch

@grctest grctest closed this as completed Aug 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@grctest