Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code Clean Up (Ape) #2055

Closed
ryanRfox opened this issue Nov 18, 2019 · 9 comments
Closed

Code Clean Up (Ape) #2055

ryanRfox opened this issue Nov 18, 2019 · 9 comments

Comments

@ryanRfox
Copy link
Contributor

ryanRfox commented Nov 18, 2019

This is a meta ticket for multiple PRs authored by @crypto-ape in previous releases. I was sloppy in requiring an Issue per PR, so let's use this for transparency. Thanks @crypto-ape for all of your contributions.

PR Estimated Effort Hours
#1693 24.00
#1792 2.00
#1809 1.00
#1810 12.00
#1811 2.00
#1812 3.00
#1910 24.00
#1950 4.00
#959 1.00
#1706 20.00
bitshares/bitshares-fc#121 36.00

Looking to Core Team reviewers ( @abitmore @pmconrad @oxarbitrage ) to ACK below regarding the estimated effort hours.

@abitmore
Copy link
Member

If @pmconrad is going to ACK I'll support his conclusion(s). Thanks.

@pmconrad
Copy link
Contributor

I think the #121 should really be bitshares/bitshares-fc#121

I value @crypto-ape 's contributions and I think the quoted hours are reasonable. ACK.

@ryanRfox
Copy link
Contributor Author

Sorry, as @pmconrad noted above the final entry is for fc (not bitshares-core).

@oxarbitrage
Copy link
Member

ACK.

@sschiessl-bcp
Copy link

@crypto-ape can you please comment on how you derived your estimates for effort hours?

@crypto-ape
Copy link
Contributor

@crypto-ape can you please comment on how you derived your estimates for effort hours?

Took the time I have already spent on the issue, rounded it down, and that is the time effort you can see in the table.

@sschiessl-bcp
Copy link

@crypto-ape can you please comment on how you derived your estimates for effort hours?

Took the time I have already spent on the issue, rounded it down, and that is the time effort you can see in the table.

Apologies for the inquiries. The core team members have been using TimeChimp provided by the BBF to track their hours, which is easily auditable for me. Have you been using time tracking software?

@crypto-ape
Copy link
Contributor

@sschiessl-bcp not a problem, I was not sure how to answer your question :)

I kept it simple as a community member, I have not been using any time-tracking system. I do have a text file, which is effectively the table you can see here.

@abitmore
Copy link
Member

Done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants