Refactor CLI register_account and create_account_with_private_key commands, remove duplicate code #1811
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oxarbitrage
previously requested changes
Jun 20, 2019
abitmore
reviewed
Jun 20, 2019
crypto-ape
force-pushed
the
cli_wallet-transaction_default_expiration_as_constant
branch
from
3ee7209
to
8389cbc
Compare
|
Refactored. Bump. |
|
@crypto-ape please rebase to latest |
…stant duplicities
crypto-ape
force-pushed
the
cli_wallet-transaction_default_expiration_as_constant
branch
from
8389cbc
to
649709f
Compare
|
Done. |
abitmore
approved these changes
Jun 26, 2019
abitmore
changed the title
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey Monkeys!
This change refactors an in-place constant used multiple times into a proper constant variable.
Ape out!