Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Value for sonar.branch.target in release and master branches? #2095

Closed
1 of 17 tasks
abitmore opened this issue Feb 6, 2020 · 3 comments · Fixed by #2102
Closed
1 of 17 tasks

Value for sonar.branch.target in release and master branches? #2095

abitmore opened this issue Feb 6, 2020 · 3 comments · Fixed by #2102
Assignees
Labels
5a Docs Needed Status specific to Documentation indicating the need for proper documentation to be added 6 Build Impact flag identifying the build process

Comments

@abitmore
Copy link
Member

abitmore commented Feb 6, 2020

Bug Description

There is a comment in sonar-project.properties:

# should be changed in hardfork branch and removed in release branches
sonar.branch.target=develop

Although I don't know what the parameter is and why the comment says so, it seems incorrect that we have that value in master branch. I think
1. when creating new release we need to update the value in master branch, and (update: 2 will obsolete 1)
2. ideally we should have a build helper script to update the value when building the project, so that we don't need to update it every time when creating a new branch, nor need to fix conflicts caused by it when merging branches.

Impacts
Describe which portion(s) of BitShares Core may be impacted by this bug. Please tick at least one box.

  • API (the application programming interface)
  • Build (the build process or something prior to compiled code)
  • CLI (the command line wallet)
  • Deployment (the deployment process after building such as Docker, Travis, etc.)
  • DEX (the Decentralized EXchange, market engine, etc.)
  • P2P (the peer-to-peer network for transaction/block propagation)
  • Performance (system or user efficiency, etc.)
  • Protocol (the blockchain logic, consensus, validation, etc.)
  • Security (the security of system or user data, etc.)
  • UX (the User Experience)
  • Other (please add below)

CORE TEAM TASK LIST

  • Evaluate / Prioritize Bug Report
  • Refine User Stories / Requirements
  • Define Test Cases
  • Design / Develop Solution
  • Perform QA/Testing
  • Update Documentation
@abitmore abitmore added the 5a Docs Needed Status specific to Documentation indicating the need for proper documentation to be added label Feb 6, 2020
@abitmore
Copy link
Member Author

abitmore commented Feb 6, 2020

Background: we introduced a change in #1750 that requires some actions when merging branches, but haven't documented it in Git Flow, so I guess nobody remembered it.

@abitmore
Copy link
Member Author

abitmore commented Feb 6, 2020

There is a related build helper script in the project.

@abitmore abitmore self-assigned this Feb 9, 2020
@abitmore abitmore added the 6 Build Impact flag identifying the build process label Feb 9, 2020
abitmore added a commit that referenced this issue Feb 9, 2020
@abitmore
Copy link
Member Author

abitmore commented Feb 9, 2020

Fixed by #2102.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5a Docs Needed Status specific to Documentation indicating the need for proper documentation to be added 6 Build Impact flag identifying the build process
Projects
None yet
1 participant