Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #210: Check required_auths on custom_operation #1629

Merged
merged 7 commits into from
Aug 13, 2019

Commits on Jul 31, 2019

  1. Resolve bitshares#210: [HF] Check authorities on custom_operation

    The required_auths field on custom_operation was being ignored during authority checking. This commit causes it to be checked correctly, and adds a unit test verifying as much.
    nathanielhourt committed Jul 31, 2019
    Configuration menu
    Copy the full SHA
    9d04ddb View commit details
    Browse the repository at this point in the history
  2. Ref bitshares#210: Add hardfork guards

    Hardfork guards are complex for this issue, because we can't access
    chain time in the operation's get_required_active_authorities() method.
    
    There was no apparent 'good' way to solve this, so I settled for a
    fairly nasty hack which seemed the least bad of bad options. Add a
    boolean parameter to the verify_authority() functions determining
    whether the custom_operation::required_auths field should be ignored or
    not, and call these functions setting the boolean appropriately for
    whether we have passed the hardfork or not. This works because chain
    time is available at the verify_authority() call sites.
    nathanielhourt committed Jul 31, 2019
    Configuration menu
    Copy the full SHA
    771e038 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    974c8b6 View commit details
    Browse the repository at this point in the history
  4. Progress bitshares#210: Requested changes

    Mostly polish, but one mistake fix as well.
    nathanielhourt committed Jul 31, 2019
    Configuration menu
    Copy the full SHA
    d5503e2 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    a081fff View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    48a5457 View commit details
    Browse the repository at this point in the history

Commits on Aug 5, 2019

  1. Configuration menu
    Copy the full SHA
    e4a1018 View commit details
    Browse the repository at this point in the history