Use by_collateral when globally settling #1672
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We'd like to remove `by_price` index at some time in the future to improve performance, thus we should avoid using the index after the hardfork. #1669
pmconrad
reviewed
Mar 24, 2019
pmconrad
reviewed
Mar 25, 2019
|
Please consider/discuss risks associated with deferring this PR to 4.0.0 Protocol Upgrade Release. |
|
This is in preparation for a future optimization. Not critical nor high-priority. |
|
It would be a bit annoying if not included in this release. E.G. need to define another HF date and etc. The "future optimization" can only take effect after the hard fork time. Postponing it means to postpone the optimization, although not critical. |
ryanRfox
modified the milestones:
Protocol Upgrade Release (3.0.0),
Protocol Upgrade Release (4.0.0)
pmconrad
previously approved these changes
Mar 26, 2019
|
We shouldn't put new things into upcoming hardfork. We'd have to either postpone the hardfork date or bypass testnet, neither of which I think is justified for this change. |
pmconrad
previously approved these changes
Apr 3, 2019
abitmore
dismissed
pmconrad’s stale review
Since it's moved to next consensus release, we need to use another HARDFORK_CORE_TIME macro.
|
@pmconrad please review again. Thanks. |
abitmore
changed the title
17 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We'd like to remove
by_priceindex at some time in the future toimprove performance, thus we should avoid using the index after the
hardfork.
#1669