Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #2060

Merged
merged 3 commits into from
Nov 21, 2019
Merged

Update README.md #2060

merged 3 commits into from
Nov 21, 2019

Conversation

ioBanker
Copy link
Member

Proposing changes that would let users have patience before giving up with running a witness node and preventing users from going throughout asking developers about why they're facing errors while setting up their witness node cli_wallet.

Proposing changes that would let users have patience before giving up with running a witness node and preventing users from going throughout asking developers about why they're facing errors while setting up their witness node cli_wallet.
README.md Outdated Show resolved Hide resolved
@abitmore abitmore mentioned this pull request Nov 20, 2019
Copy link
Contributor

@pmconrad pmconrad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. It's always good to have fresh eyes check the documentation.

README.md Outdated Show resolved Hide resolved
@pmconrad
Copy link
Contributor

Please rebase your changes on the current release branch and force-push.

@ioBanker ioBanker changed the base branch from release332 to release November 21, 2019 13:22
Copy link
Contributor

@pmconrad pmconrad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@abitmore abitmore changed the base branch from release to release332 November 21, 2019 20:05
@abitmore
Copy link
Member

@pmconrad why current release? I asked @ioBanker it to PR against release332 to get it faster to master since everyone visiting this repository will see docs in master branch by default.

@abitmore abitmore merged commit 4a0fec8 into bitshares:release332 Nov 21, 2019
@pmconrad
Copy link
Contributor

Sorry, didn't know it was urgent. The natural way to get it into master seemed to be the release branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants