Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

return lowest_ask and highest_bid order volume #2162

Closed
wants to merge 2 commits into from

Conversation

crazybits
Copy link
Contributor

this PR related to discussion of #2001 to return more useful data in ticker.

before change

{
    "id":3,
    "result":{
        "time":"2020-04-28T15:22:24",
        "base":"CNY",
        "quote":"BTS",
        "latest":"0.224489795918367346",
        "lowest_ask":"0.224634524247316643",
        "highest_bid":"0.224529552603249653",
        "percent_change":"-0.01",
        "base_volume":"386624.9459",
        "quote_volume":"1722080.6122"
    }
}

after change

{
    "id":3,
    "result":{
        "time":"2020-04-28T15:22:24",
        "base":"CNY",
        "quote":"BTS",
        "latest":"0.224489795918367346",
        "lowest_ask":"0.224634524247316643",
        "lowest_ask_base_size":"304.8588",
        "lowest_ask_quote_size":"1357.13244",
        "highest_bid":"0.224529552603249653",
        "highest_bid_base_size":"2288.6050",
        "highest_bid_quote_size":"10192.88986",
        "percent_change":"-0.01",
        "base_volume":"386624.9459",
        "quote_volume":"1722080.6122"
    }
}

Copy link
Member

@abitmore abitmore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

libraries/app/api_objects.cpp Show resolved Hide resolved
libraries/app/include/graphene/app/api_objects.hpp Outdated Show resolved Hide resolved
@abitmore abitmore added this to the 4.1.0 - Feature Release milestone Apr 28, 2020
@abitmore
Copy link
Member

This change is quite small, perhaps rebase onto hardfork branch then we can add it in the 4.0 release.

@abitmore
Copy link
Member

abitmore commented May 1, 2020

If not rebased onto hardfork, this PR will be merged after Github Auto-Build got fixed (#2112).

@crazybits
Copy link
Contributor Author

If not rebased onto hardfork, this PR will be merged after Github Auto-Build got fixed (#2112).

to many conflicts if rebase these changes to "hardfork" branch, to make it easier, i could close this PR and cherry-pick the changes to hardfork branch, then raise PR again to hardfork branch, it that fine?@abit

@oxarbitrage
Copy link
Member

That is fine @crazybits

@crazybits
Copy link
Contributor Author

new PR has been raised #2166

@crazybits crazybits closed this May 3, 2020
@abitmore abitmore removed this from the 4.1.0 - Feature Release milestone May 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants