Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement liquidity pool #2261

Merged
merged 18 commits into from
Sep 17, 2020
Merged

Implement liquidity pool #2261

merged 18 commits into from
Sep 17, 2020

Conversation

abitmore
Copy link
Member

@abitmore abitmore commented Sep 14, 2020 •
edited
Loading

PR for #2260. The implementation is a variant of BSIP78 (draft): bitshares/bsips#213.

Bumped FC for #2255.

Ready for review.

@abitmore abitmore linked an issue Sep 14, 2020 that may be closed by this pull request
Implement Automated Market Maker (AMM) aka Liquidity Pool #2260
Closed
17 tasks
@abitmore abitmore marked this pull request as ready for review September 15, 2020 01:58
@abitmore
Copy link
Member Author

Ready for review.

@abitmore abitmore linked an issue Sep 15, 2020 that may be closed by this pull request
Bump FC for 5.0 #2255
Closed
ioBanker
ioBanker previously approved these changes Sep 16, 2020
View reviewed changes
Copy link
Member

@ioBanker ioBanker left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to our review of core code changes for implementing liquidity pool PR #2261 ; we've concluded the following:

  1. A new 5 blockchain operations have been integrated carefully within core code structure:

     - liquidity_pool_create_operation
 - liquidity_pool_delete_operation
 - liquidity_pool_deposit_operation
 - liquidity_pool_withdraw_operation
 - liquidity_pool_exchange_operation

  2. Liquidity pool exchange operation is independent of current order book engine operations, this would ease the development further of liquidity pool without disturbing the existing order book engine.

  3. Liquidity pool ownership structure is inherited from UIA ownership as object; this was very smart idea to minimize code changes and code complexities behind ownership and authority.

  4. Liquidity pool create/delete/deposit/exchange/withdraw structures are simple and satisfying the concept BSIP78: Asset Feature - MLP2 (Market Liquidity Pool) bsips#213

@abitmore abitmore mentioned this pull request Sep 16, 2020
Closed
17 tasks
@shulthz
Copy link

shulthz commented Sep 17, 2020

I think this also needs a simultaneous development of UI.

@abitmore abitmore merged commit e3fb038 into bitshares:develop Sep 17, 2020
This was referenced Sep 18, 2020
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ioBanker ioBanker ioBanker left review comments

Assignees
No one assigned
Labels
hardfork
Projects
None yet
Milestone
5.0.0 - Protocol Upgrade Release
Development

Successfully merging this pull request may close these issues.

Implement Automated Market Maker (AMM) aka Liquidity Pool Bump FC for 5.0
3 participants
@abitmore @shulthz @ioBanker