Remove unavailable item from active sync requests, fix node stuck issue #2445
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When got an `item_not_available_message` from a peer, the item was removed from the `sync_items_requested_from_peer` list of the peer, but it was left in the `_active_sync_requests` list. When disconnecting from the peer, since the `sync_items_requested_from_peer` list of the peer no longer contains the item, the cleanup process does not remove it from the `_active_sync_requests` list either. As a result, the node will not request the item from another peer, thus gets stuck.
3 tasks
3 tasks
|
Kudos, SonarCloud Quality Gate passed! |
|
Thanks. |
Gandalf-the-Grey
pushed a commit
to openhive-network/hive
that referenced
this pull request
May 5, 2021
Gandalf-the-Grey
pushed a commit
to openhive-network/hive
that referenced
this pull request
May 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2434 (node gets stuck when syncing).
When got an
item_not_available_messagefrom a peer, the item wasremoved from the
sync_items_requested_from_peerlist of the peer,but it was left in the
_active_sync_requestslist.When disconnecting from the peer, since the
sync_items_requested_from_peerlist of the peer no longer containsthe item, the cleanup process does not remove it from the
_active_sync_requestslist either.As a result, the node will not request the item from another peer,
thus gets stuck.
This Ci job reproduces the issue: https://github.com/abitmore/bitshares-core/runs/2491471762 ,
this CI job verifies the fix: https://github.com/abitmore/bitshares-core/runs/2491784005 (note: the log files are large).