Fix code smells #2745
Merged
Fix code smells #2745
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abitmore
force-pushed
the
fix-coverage
branch
2 times, most recently
from
7e92562
to
46dd57e
Compare
|
Kudos, SonarCloud Quality Gate passed! |
This was referenced May 19, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GCOVR_EXCL_LINEmarkers to someFC_CAPTURE_*lines so that the code coverage reports make more sense.Note: the
GCOVR_EXCL_BR_LINEmarker would make even more sense for us, but it's added ingcovrversion6.0, in our main CI environment (Ubuntu 20.04 LTS) the version ofgcovris4.2(see https://gcovr.com/en/6.0/guide/exclusion-markers.html and https://gcovr.com/en/5.2/guide/exclusion-markers.html).