Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update bsip-0072.md #268

Merged
merged 2 commits into from
Mar 31, 2020
Merged

Update bsip-0072.md #268

merged 2 commits into from
Mar 31, 2020

Conversation

nathanielhourt
Copy link
Contributor

This updates the Tanks and Taps description and specification for clarity and correctness based on changes made to the protocol during implementation.

This updates the Tanks and Taps description and specification for clarity and correctness based on changes made to the protocol during implementation.
@sschiessl-bcp
Copy link
Collaborator

sschiessl-bcp commented Mar 17, 2020

Could you present a gist of changes pretty please?

Were they all technical of nature?

@nathanielhourt
Copy link
Contributor Author

Most of the changes are technical, but there are also some alterations in the abstract and motivation sections to make clearer what Tanks and Taps is and is not. I realized that readers might misunderstand that TNT adds turing complete functionality, so I added a statement that it does not. Changes like that. The rich diff should make those alterations readily evident.

The bulk of the changes is in the specification section, correcting the spec to account for things added and removed during implementation. Most notably, the concept of the sink was dropped in favor of the connection, and the deposit_source_restrictor was removed. These changes were made because I realized during implementation that the TNT structures were too trusting by default and it was easy to create structures that work in the intended fashion, but also in unintended fashions. The updates adjust the defaults so that security is built throughout the structures and not left as an add-on at the end. Created structures should now only work in the intended fashion, no surprises.

@sschiessl-bcp
Copy link
Collaborator

Looks good to me. Since this BSIP is already created on-chain to be voted on, I would like to ask @abitmore to have a look. I think the changes are not significant enough to warrant a re-voting.

@nathanielhourt
Copy link
Contributor Author

nathanielhourt commented Mar 23, 2020

Yeah, that was something I considered; I'm not sure how much editing BSIPs is a thing... Is there some other way I should go about publishing this update?

@abitmore
Copy link
Member

Sorry, I haven't made chance to thoroughly review the original BSIP yet, but trusted other reviewers, so please don't expect my opinions on this PR soon.

@MichelSantos
Copy link
Contributor

I think the changes are not significant enough to warrant a re-voting.

For whatever it's worth, I agree that the changes are technical improvements that do not alter the spirit of the specifications.

@sschiessl-bcp sschiessl-bcp merged commit 4f897cf into bitshares:master Mar 31, 2020
@nathanielhourt nathanielhourt deleted the patch-2 branch April 1, 2020 23:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants