-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update bsip-0072.md #268
Update bsip-0072.md #268
Conversation
This updates the Tanks and Taps description and specification for clarity and correctness based on changes made to the protocol during implementation.
Could you present a gist of changes pretty please? Were they all technical of nature? |
Most of the changes are technical, but there are also some alterations in the abstract and motivation sections to make clearer what Tanks and Taps is and is not. I realized that readers might misunderstand that TNT adds turing complete functionality, so I added a statement that it does not. Changes like that. The rich diff should make those alterations readily evident. The bulk of the changes is in the specification section, correcting the spec to account for things added and removed during implementation. Most notably, the concept of the |
Looks good to me. Since this BSIP is already created on-chain to be voted on, I would like to ask @abitmore to have a look. I think the changes are not significant enough to warrant a re-voting. |
Yeah, that was something I considered; I'm not sure how much editing BSIPs is a thing... Is there some other way I should go about publishing this update? |
Sorry, I haven't made chance to thoroughly review the original BSIP yet, but trusted other reviewers, so please don't expect my opinions on this PR soon. |
For whatever it's worth, I agree that the changes are technical improvements that do not alter the spirit of the specifications. |
This updates the Tanks and Taps description and specification for clarity and correctness based on changes made to the protocol during implementation.