Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove serde_derive #385

Merged
merged 6 commits into from
Mar 18, 2023
Merged

Conversation

jakobhellermann
Copy link
Contributor

alternative to #384

Cuts the critical compilation chain of bevy further from syn -> serde_derive -> glam -> bevy_math -> bevy_reflect to syn -> bevy_reflect_derive -> bevy_reflect which is a few seconds faster.

but it makes the code less maintainable (especially if you plan to add more types with a serde derives so I can understand if you don't want to merge this. I just copied the output of rust-analyzer's Expand macro recursively and cleaned it up a bit.

@bitshifter
Copy link
Owner

Seems like this doesn't work with no_std.

@bitshifter
Copy link
Owner

bitshifter commented Mar 16, 2023

Since this was the only type using derive I'm OK with providing an implementation by hand.

It should move to src/features/impl_serde.rs with the rest of them though.

It might warrant adding a test to that file as well.

Copy link
Owner

@bitshifter bitshifter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good but this should move to src/features/impl_serde.rs.

@bitshifter bitshifter merged commit e233f79 into bitshifter:main Mar 18, 2023
@bitshifter
Copy link
Owner

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants