Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[AC-1387] Resource-based authentication for Groups #2845

Closed
wants to merge 53 commits into from
Closed

[AC-1387] Resource-based authentication for Groups #2845

wants to merge 53 commits into from

Commits on Apr 10, 2023

  1. Initial proof of concept for resource based auth

    @eliykat
    eliykat committed Apr 10, 2023
    Configuration menu
    Copy the full SHA
    73219ea View commit details
    Browse the repository at this point in the history

  2. Use generic CRUD operations, remove unnecessary policies

    @eliykat
    eliykat committed Apr 10, 2023
    Configuration menu
    Copy the full SHA
    09815d6 View commit details
    Browse the repository at this point in the history

  3. Remove unused deps

    @eliykat
    eliykat committed Apr 10, 2023
    Configuration menu
    Copy the full SHA
    313a5ae View commit details
    Browse the repository at this point in the history

Commits on Apr 11, 2023

  1. Fill out the rest of GroupsController

    @eliykat
    eliykat committed Apr 11, 2023
    Configuration menu
    Copy the full SHA
    22db106 View commit details
    Browse the repository at this point in the history

  2. Move CreateGroup to Groups auth handler

    @eliykat
    eliykat committed Apr 11, 2023
    Configuration menu
    Copy the full SHA
    ad3edfb View commit details
    Browse the repository at this point in the history

  3. Add proper 403 exception and status code

    @eliykat
    eliykat committed Apr 11, 2023
    Configuration menu
    Copy the full SHA
    1ce0c89 View commit details
    Browse the repository at this point in the history

Commits on Apr 12, 2023

  1. Enable nullable where required

    @eliykat
    eliykat committed Apr 12, 2023
    Configuration menu
    Copy the full SHA
    4897086 View commit details
    Browse the repository at this point in the history

  2. Use Guids instead of strings

    @eliykat
    eliykat committed Apr 12, 2023
    Configuration menu
    Copy the full SHA
    1da60bb View commit details
    Browse the repository at this point in the history

  3. Unabbreviate Authorization

    @eliykat
    eliykat committed Apr 12, 2023
    Configuration menu
    Copy the full SHA
    c6c5a31 View commit details
    Browse the repository at this point in the history

  4. Use nameof instead of string literals

    @eliykat
    eliykat committed Apr 12, 2023
    Configuration menu
    Copy the full SHA
    68ed862 View commit details
    Browse the repository at this point in the history

  5. Use named tuples

    @eliykat
    eliykat committed Apr 12, 2023
    Configuration menu
    Copy the full SHA
    7ae2162 View commit details
    Browse the repository at this point in the history

  6. Fix EF return tuple

    @eliykat
    eliykat committed Apr 12, 2023
    Configuration menu
    Copy the full SHA
    7fa4d15 View commit details
    Browse the repository at this point in the history

  7. Assign default Permissions object, remove null checks

    @eliykat
    eliykat committed Apr 12, 2023
    Configuration menu
    Copy the full SHA
    22fa5b8 View commit details
    Browse the repository at this point in the history

  8. Fix structure and async stuff in handlers

    @eliykat
    eliykat committed Apr 12, 2023
    Configuration menu
    Copy the full SHA
    33a7a6d View commit details
    Browse the repository at this point in the history

Commits on Apr 24, 2023

  1. Merge branch 'master' into experiment/resource-based-auth

    @eliykat
    eliykat committed Apr 24, 2023
    Configuration menu
    Copy the full SHA
    bde9519 View commit details
    Browse the repository at this point in the history

Commits on Apr 25, 2023

  1. Use switch statements

    @eliykat
    eliykat committed Apr 25, 2023
    Configuration menu
    Copy the full SHA
    1936bbe View commit details
    Browse the repository at this point in the history

  2. Revert "Add proper 403 exception and status code" 

    This reverts commit 1ce0c89.
    @eliykat
    eliykat committed Apr 25, 2023
    Configuration menu
    Copy the full SHA
    a2ed58b View commit details
    Browse the repository at this point in the history

  3. Check for null within auth handler

    @eliykat
    eliykat committed Apr 25, 2023
    Configuration menu
    Copy the full SHA
    9fba463 View commit details
    Browse the repository at this point in the history

  4. Create extension methods for AuthService

    @eliykat
    eliykat committed Apr 25, 2023
    Configuration menu
    Copy the full SHA
    639b07b View commit details
    Browse the repository at this point in the history

  5. Treat GroupUsers as their own resource 

    - Add repository method to get GroupUser
- Add AuthorizationHandler for GroupUser
- Move group-organization-organizationUser validation into controllers
    @eliykat
    eliykat committed Apr 25, 2023
    Configuration menu
    Copy the full SHA
    933af46 View commit details
    Browse the repository at this point in the history

  6. Create shim methods for individual requirements

    @eliykat
    eliykat committed Apr 25, 2023
    Configuration menu
    Copy the full SHA
    fee6057 View commit details
    Browse the repository at this point in the history

  7. Fix line breaks

    @eliykat
    eliykat committed Apr 25, 2023
    Configuration menu
    Copy the full SHA
    f4c7324 View commit details
    Browse the repository at this point in the history

  8. Remove unnecessary comment

    @eliykat
    eliykat committed Apr 25, 2023
    Configuration menu
    Copy the full SHA
    e1468c2 View commit details
    Browse the repository at this point in the history

  9. Add extra null checks

    @eliykat
    eliykat committed Apr 25, 2023
    Configuration menu
    Copy the full SHA
    50399e8 View commit details
    Browse the repository at this point in the history

Commits on Apr 26, 2023

  1. Remove GroupService

    @eliykat
    eliykat committed Apr 26, 2023
    Configuration menu
    Copy the full SHA
    af23ee5 View commit details
    Browse the repository at this point in the history

  2. Add bitAuthorizationService and update tests

    @eliykat
    eliykat committed Apr 26, 2023
    Configuration menu
    Copy the full SHA
    29a6d23 View commit details
    Browse the repository at this point in the history

Commits on Apr 27, 2023

  1. Suggestion: move ReadAllGroups into group authorizationHandler

    @eliykat
    eliykat committed Apr 27, 2023
    Configuration menu
    Copy the full SHA
    bf77e5a View commit details
    Browse the repository at this point in the history

  2. Revert "Suggestion: move ReadAllGroups into group authorizationHandler" 

    This reverts commit bf77e5a.
    @eliykat
    eliykat committed Apr 27, 2023
    Configuration menu
    Copy the full SHA
    e577c24 View commit details
    Browse the repository at this point in the history

Commits on May 9, 2023

  1. Merge branch 'master' into experiment/resource-based-auth

    @eliykat
    eliykat committed May 9, 2023
    Configuration menu
    Copy the full SHA
    2c06a80 View commit details
    Browse the repository at this point in the history

  2. Add provider checks using CurrentContext

    @eliykat
    eliykat committed May 9, 2023
    Configuration menu
    Copy the full SHA
    f3681e2 View commit details
    Browse the repository at this point in the history

Commits on May 10, 2023

  1. Move ReadAllGroups requirement into group handler

    @eliykat
    eliykat committed May 10, 2023
    Configuration menu
    Copy the full SHA
    e5f971e View commit details
    Browse the repository at this point in the history

  2. Fix sql syntax and update date

    @eliykat
    eliykat committed May 10, 2023
    Configuration menu
    Copy the full SHA
    3c52440 View commit details
    Browse the repository at this point in the history

  3. Fix comments and spacing

    @eliykat
    eliykat committed May 10, 2023
    Configuration menu
    Copy the full SHA
    d73c81e View commit details
    Browse the repository at this point in the history

  4. Fix sql syntax

    @eliykat
    eliykat committed May 10, 2023
    Configuration menu
    Copy the full SHA
    1cc18d4 View commit details
    Browse the repository at this point in the history

  5. Run dotnet format

    @eliykat
    eliykat committed May 10, 2023
    Configuration menu
    Copy the full SHA
    7f70cd3 View commit details
    Browse the repository at this point in the history

  6. Delete unused code

    @eliykat
    eliykat committed May 10, 2023
    Configuration menu
    Copy the full SHA
    27ff510 View commit details
    Browse the repository at this point in the history

  7. Fix tests

    @eliykat
    eliykat committed May 10, 2023
    Configuration menu
    Copy the full SHA
    4855003 View commit details
    Browse the repository at this point in the history

  8. Minor tweaks

    @eliykat
    eliykat committed May 10, 2023
    Configuration menu
    Copy the full SHA
    6024216 View commit details
    Browse the repository at this point in the history

Commits on May 11, 2023

  1. Remove DeleteGroupCommand

    @eliykat
    eliykat committed May 11, 2023
    Configuration menu
    Copy the full SHA
    2599427 View commit details
    Browse the repository at this point in the history

  2. Fix error message

    @eliykat
    eliykat committed May 11, 2023
    Configuration menu
    Copy the full SHA
    89c65b9 View commit details
    Browse the repository at this point in the history

  3. Remove #nullable from CurrentContext

    @eliykat
    eliykat committed May 11, 2023
    Configuration menu
    Copy the full SHA
    3464d57 View commit details
    Browse the repository at this point in the history

Commits on May 23, 2023

  1. Merge branch 'master' into experiment/resource-based-auth

    @eliykat
    eliykat committed May 23, 2023
    Configuration menu
    Copy the full SHA
    719fcba View commit details
    Browse the repository at this point in the history

  2. Fix order of using/namespace

    @eliykat
    eliykat committed May 23, 2023
    Configuration menu
    Copy the full SHA
    4465e1a View commit details
    Browse the repository at this point in the history

  3. Make ReadAllForOrganization a static method

    @eliykat
    eliykat committed May 23, 2023
    Configuration menu
    Copy the full SHA
    f62a4f5 View commit details
    Browse the repository at this point in the history

Commits on May 29, 2023

  1. Merge remote-tracking branch 'origin/master' into experiment/resource… 

    …-based-auth
    @eliykat
    eliykat committed May 29, 2023
    Configuration menu
    Copy the full SHA
    8413679 View commit details
    Browse the repository at this point in the history

  2. Remove access modifier in interface

    @eliykat
    eliykat committed May 29, 2023
    Configuration menu
    Copy the full SHA
    6bba9f3 View commit details
    Browse the repository at this point in the history

  3. Update date on sproc

    @eliykat
    eliykat committed May 29, 2023
    Configuration menu
    Copy the full SHA
    c5583ab View commit details
    Browse the repository at this point in the history

  4. Use PascalCase for named tuple

    @eliykat
    eliykat committed May 29, 2023
    Configuration menu
    Copy the full SHA
    eeb78a9 View commit details
    Browse the repository at this point in the history

  5. Add comment

    @eliykat
    eliykat committed May 29, 2023
    Configuration menu
    Copy the full SHA
    5753267 View commit details
    Browse the repository at this point in the history

Commits on May 30, 2023

  1. Finish updating named tuple case

    @eliykat
    eliykat committed May 30, 2023
    Configuration menu
    Copy the full SHA
    0ee583d View commit details
    Browse the repository at this point in the history

  2. Finish updating named tuple case

    @eliykat
    eliykat committed May 30, 2023
    Configuration menu
    Copy the full SHA
    b7b8053 View commit details
    Browse the repository at this point in the history

Commits on Aug 27, 2023

  1. Merge remote-tracking branch 'origin/master' into experiment/resource… 

    …-based-auth
    @eliykat
    eliykat committed Aug 27, 2023
    Configuration menu
    Copy the full SHA
    d5b68d8 View commit details
    Browse the repository at this point in the history

Commits on Aug 28, 2023

  1. dotnet format

    @eliykat
    eliykat committed Aug 28, 2023
    Configuration menu
    Copy the full SHA
    23622ee View commit details
    Browse the repository at this point in the history