Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-11123] Service layer for Notification Center #4741

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

Conversation

mzieniukbw
Copy link
Contributor

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-11123

📔 Objective

Create service layer for new database storage.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@mzieniukbw mzieniukbw changed the base branch from main to km/pm-10560 September 6, 2024 08:56
@mzieniukbw mzieniukbw changed the title km/pm-11123 [PM-11123] Service layer for Notification Center Sep 6, 2024
Copy link

codecov bot commented Sep 6, 2024

Codecov Report

Attention: Patch coverage is 7.59494% with 365 lines in your changes missing coverage. Please review.

Project coverage is 41.49%. Comparing base (c839280) to head (6201b35).

Files with missing lines Patch % Lines
.../Authorization/NotificationAuthorizationHandler.cs 6.89% 54 Missing ⚠️
...nCenter/Commands/MarkNotificationDeletedCommand.cs 0.00% 54 Missing ⚠️
...tionCenter/Commands/MarkNotificationReadCommand.cs 0.00% 54 Missing ⚠️
...Center/Commands/UpdateNotificationStatusCommand.cs 0.00% 34 Missing ⚠️
...Center/Commands/CreateNotificationStatusCommand.cs 0.00% 27 Missing ⚠️
...rization/NotificationStatusAuthorizationHandler.cs 13.79% 25 Missing ⚠️
...cationCenter/Commands/UpdateNotificationCommand.cs 0.00% 25 Missing ⚠️
...enter/Queries/GetNotificationStatusForUserQuery.cs 0.00% 24 Missing ⚠️
...tionCenter/Queries/GetNotificationsForUserQuery.cs 0.00% 24 Missing ⚠️
...ficationCenter/Queries/GetNotificationByIdQuery.cs 0.00% 20 Missing ⚠️
... and 3 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4741      +/-   ##
==========================================
- Coverage   41.70%   41.49%   -0.22%     
==========================================
  Files        1308     1321      +13     
  Lines       61983    62378     +395     
  Branches     5707     5762      +55     
==========================================
+ Hits        25852    25882      +30     
- Misses      34940    35305     +365     
  Partials     1191     1191              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented Sep 6, 2024

Logo
Checkmarx One – Scan Summary & Details89f9ca0a-c61e-45d9-8cee-a11545b8728c

New Issues

Severity Issue Source File / Package Checkmarx Insight
MEDIUM Privacy_Violation /src/Api/Auth/Controllers/TwoFactorController.cs: 488 Attack Vector
MEDIUM Privacy_Violation /src/Api/Auth/Controllers/WebAuthnController.cs: 178 Attack Vector
MEDIUM Privacy_Violation /src/Api/Controllers/DevicesController.cs: 133 Attack Vector
MEDIUM Privacy_Violation /src/Api/Auth/Controllers/AccountsController.cs: 847 Attack Vector
MEDIUM Privacy_Violation /src/Api/Auth/Controllers/AccountsController.cs: 829 Attack Vector
MEDIUM Privacy_Violation /src/Api/Auth/Controllers/AccountsController.cs: 412 Attack Vector
MEDIUM Privacy_Violation /src/Api/Auth/Controllers/AccountsController.cs: 549 Attack Vector
MEDIUM Privacy_Violation /src/Api/Vault/Controllers/CiphersController.cs: 906 Attack Vector
MEDIUM Privacy_Violation /src/Api/AdminConsole/Controllers/OrganizationsController.cs: 259 Attack Vector
MEDIUM Privacy_Violation /src/Api/Controllers/DevicesController.cs: 159 Attack Vector
MEDIUM Privacy_Violation /src/Api/AdminConsole/Controllers/OrganizationsController.cs: 403 Attack Vector
MEDIUM Privacy_Violation /src/Api/AdminConsole/Controllers/OrganizationsController.cs: 350 Attack Vector
LOW Log_Forging /src/Api/Auth/Controllers/WebAuthnController.cs: 68 Attack Vector
LOW Log_Forging /src/Api/Auth/Controllers/WebAuthnController.cs: 153 Attack Vector
LOW Log_Forging /src/Api/Auth/Controllers/WebAuthnController.cs: 85 Attack Vector
LOW Log_Forging /src/Billing/Controllers/StripeController.cs: 164 Attack Vector
LOW Log_Forging /src/Billing/Controllers/StripeController.cs: 164 Attack Vector
LOW Log_Forging /src/Billing/Controllers/StripeController.cs: 164 Attack Vector
LOW Log_Forging /src/Billing/Controllers/StripeController.cs: 164 Attack Vector
LOW Log_Forging /src/Billing/Controllers/StripeController.cs: 164 Attack Vector
LOW Log_Forging /src/Billing/Controllers/StripeController.cs: 164 Attack Vector
LOW Log_Forging /src/Api/Vault/Controllers/CiphersController.cs: 898 Attack Vector
LOW Log_Forging /src/Api/Auth/Controllers/AccountsController.cs: 839 Attack Vector
LOW Log_Forging /src/Api/Auth/Controllers/AccountsController.cs: 821 Attack Vector
LOW Log_Forging /src/Api/Auth/Controllers/AccountsController.cs: 541 Attack Vector
LOW Log_Forging /src/Api/Controllers/DevicesController.cs: 124 Attack Vector
LOW Log_Forging /src/Api/Auth/Controllers/AccountsController.cs: 404 Attack Vector
LOW Log_Forging /src/Api/AdminConsole/Controllers/OrganizationsController.cs: 239 Attack Vector
LOW Log_Forging /src/Api/Controllers/DevicesController.cs: 150 Attack Vector
LOW Log_Forging /src/Api/AdminConsole/Controllers/OrganizationsController.cs: 378 Attack Vector
LOW Log_Forging /src/Api/AdminConsole/Controllers/OrganizationsController.cs: 315 Attack Vector

Fixed Issues

Severity Issue Source File / Package
MEDIUM CSRF /src/Api/Controllers/DevicesController.cs: 74
MEDIUM CSRF /src/Api/Controllers/DevicesController.cs: 61
MEDIUM CSRF /src/Api/AdminConsole/Public/Controllers/MembersController.cs: 98
MEDIUM CSRF /src/Api/AdminConsole/Controllers/ProviderOrganizationsController.cs: 48
MEDIUM CSRF /src/Api/AdminConsole/Public/Controllers/MembersController.cs: 98
MEDIUM CSRF /src/Api/AdminConsole/Controllers/OrganizationUsersController.cs: 218
MEDIUM CSRF /src/Api/AdminConsole/Controllers/OrganizationsController.cs: 478
MEDIUM CSRF /src/Api/AdminConsole/Controllers/OrganizationUsersController.cs: 272
MEDIUM CSRF /src/Api/AdminConsole/Controllers/OrganizationUsersController.cs: 540
MEDIUM CSRF /src/Api/AdminConsole/Controllers/OrganizationsController.cs: 503
MEDIUM CSRF /src/Api/Billing/Public/Controllers/OrganizationController.cs: 47
MEDIUM CSRF /src/Api/AdminConsole/Controllers/OrganizationsController.cs: 445
MEDIUM CSRF /src/Api/AdminConsole/Controllers/OrganizationsController.cs: 478
MEDIUM CSRF /src/Api/AdminConsole/Controllers/OrganizationsController.cs: 176
MEDIUM CSRF /src/Api/AdminConsole/Controllers/OrganizationUsersController.cs: 554
MEDIUM CSRF /src/Api/AdminConsole/Controllers/ProviderOrganizationsController.cs: 48
MEDIUM CSRF /src/Api/Controllers/DevicesController.cs: 74
MEDIUM CSRF /src/Api/Controllers/DevicesController.cs: 61

Base automatically changed from km/pm-10560 to main September 9, 2024 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant