-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PM-8108] Add Duo SDK v4 metadata to Duo Two Factor Provider #4774
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4774 +/- ##
=======================================
Coverage 41.79% 41.79%
=======================================
Files 1308 1308
Lines 62051 62051
Branches 5716 5716
=======================================
Hits 25936 25936
Misses 34921 34921
Partials 1194 1194 ☔ View full report in Codecov by Sentry. |
New Issues
Fixed Issues
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM at a high level!
🎟️ Tracking
PM-8108
📔 Objective
We have been using Duo SDK v4 for some time and in order to remove v2 from our code base we need to purge the v2 metadata from the database. To do this we first need to guarantee v4 data. This PR copies the data from the v2 metadata into the correct v4 metadata.
The MSSQL version of the process utilizes Batch processing to ensure high availability for our production instance.
The entity framework scripts are straight forward
UPDATE
statements, which may be more blocking but should run quickly.📸 Screenshots
There are no screenshots available.
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:
) or similar for great changes:memo:
) or ℹ️ (:information_source:
) for notes or general info:question:
) for questions:thinking:
) or 💭 (:thought_balloon:
) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:
) for suggestions / improvements:x:
) or:warning:
) for more significant problems or concerns needing attention:seedling:
) or ♻️ (:recycle:
) for future improvements or indications of technical debt:pick:
) for minor or nitpick changes