Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-8108] Add Duo SDK v4 metadata to Duo Two Factor Provider #4774

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

ike-kottlowski
Copy link
Contributor

@ike-kottlowski ike-kottlowski commented Sep 13, 2024

🎟️ Tracking

PM-8108

📔 Objective

We have been using Duo SDK v4 for some time and in order to remove v2 from our code base we need to purge the v2 metadata from the database. To do this we first need to guarantee v4 data. This PR copies the data from the v2 metadata into the correct v4 metadata.

The MSSQL version of the process utilizes Batch processing to ensure high availability for our production instance.

The entity framework scripts are straight forward UPDATE statements, which may be more blocking but should run quickly.

📸 Screenshots

There are no screenshots available.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@ike-kottlowski ike-kottlowski requested a review from a team as a code owner September 13, 2024 23:42
Copy link

codecov bot commented Sep 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 41.79%. Comparing base (e5c77d5) to head (1335fd5).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4774   +/-   ##
=======================================
  Coverage   41.79%   41.79%           
=======================================
  Files        1308     1308           
  Lines       62051    62051           
  Branches     5716     5716           
=======================================
  Hits        25936    25936           
  Misses      34921    34921           
  Partials     1194     1194           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ike-kottlowski ike-kottlowski changed the title [PM-8108] Add v4 metadata to Duo Two Factor Provider [PM-8108] Add Duo SDK v4 metadata to Duo Two Factor Provider Sep 13, 2024
Copy link
Contributor

github-actions bot commented Sep 14, 2024

Logo
Checkmarx One – Scan Summary & Details0425d0e5-ce66-4532-8fa9-38f157605e52

New Issues

Severity Issue Source File / Package Checkmarx Insight
HIGH Passwords And Secrets - Generic Password /test-database.yml: 177 Query to find passwords and secrets in infrastructure code.
HIGH Passwords And Secrets - Generic Password /test-database.yml: 173 Query to find passwords and secrets in infrastructure code.
HIGH Passwords And Secrets - Generic Password /test-database.yml: 170 Query to find passwords and secrets in infrastructure code.
MEDIUM CSRF /src/Api/AdminConsole/Controllers/OrganizationsController.cs: 478 Attack Vector
MEDIUM CSRF /src/Api/AdminConsole/Controllers/OrganizationUsersController.cs: 565 Attack Vector
MEDIUM CSRF /src/Api/AdminConsole/Controllers/OrganizationsController.cs: 503 Attack Vector
MEDIUM CSRF /src/Api/AdminConsole/Controllers/OrganizationUsersController.cs: 551 Attack Vector
MEDIUM CSRF /src/Api/Billing/Public/Controllers/OrganizationController.cs: 47 Attack Vector
MEDIUM CSRF /src/Api/AdminConsole/Controllers/OrganizationsController.cs: 445 Attack Vector
MEDIUM CSRF /src/Api/AdminConsole/Controllers/OrganizationsController.cs: 176 Attack Vector
MEDIUM CSRF /src/Api/AdminConsole/Controllers/OrganizationsController.cs: 478 Attack Vector
MEDIUM CSRF /src/Api/AdminConsole/Controllers/OrganizationUsersController.cs: 283 Attack Vector

Fixed Issues

Severity Issue Source File / Package
HIGH Passwords And Secrets - Generic Password /test-database.yml: 182
HIGH Passwords And Secrets - Generic Password /test-database.yml: 185
HIGH Passwords And Secrets - Generic Password /test-database.yml: 189
LOW Log_Forging /src/Billing/Controllers/StripeController.cs: 164

Copy link
Contributor

@rkac-bw rkac-bw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@JaredSnider-Bitwarden JaredSnider-Bitwarden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM at a high level!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants