Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate test logger in favour of new Zap test logger #104

Merged
merged 4 commits into from
Nov 2, 2018
Merged

Deprecate test logger in favour of new Zap test logger #104

merged 4 commits into from
Nov 2, 2018

Conversation

JeanMertz
Copy link
Contributor

@JeanMertz
deprecate streamutil.Logger
e2dc66b 
Zap now has a built-in zaptest.NewLogger that exposes the same
functionality.
@JeanMertz JeanMertz force-pushed the deprecate-logger branch 3 times, most recently from d104a28 to 26c31bf Compare November 2, 2018 09:06
@JeanMertz
Install latest stable gometalinter on CI
bbf136f 
This prevents intermittent linting issues on CI when gometalinter (master)
is changed.
@JeanMertz JeanMertz changed the base branch from update-dependencies to master November 2, 2018 16:43
@JeanMertz JeanMertz merged commit 0040460 into master Nov 2, 2018
@JeanMertz JeanMertz deleted the deprecate-logger branch November 2, 2018 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jurre jurre jurre approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JeanMertz @jurre