Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: generate JSON for arbitrary CBOR #355

Merged
merged 1 commit into from
Jul 1, 2023
Merged

feat: generate JSON for arbitrary CBOR #355

merged 1 commit into from
Jul 1, 2023

Conversation

agaffney
Copy link
Contributor

Fixes #305

@agaffney agaffney requested a review from wolf31o2 as a code owner June 30, 2023 19:39
@github-actions
Copy link

Test coverage changes:

Package Before After Diff
github.com/blinklabs-io/gouroboros/cbor 48% 35% ❌

github-advanced-security[bot]
github-advanced-security bot found potential problems Jun 30, 2023
View reviewed changes
cbor/value.go Dismissed Show dismissed Hide dismissed
@agaffney agaffney force-pushed the feat/cbor-value-structure branch 2 times, most recently from b2fc934 to 8fe53ad Compare June 30, 2023 19:45
wolf31o2
wolf31o2 requested changes Jun 30, 2023
View reviewed changes
Copy link
Member

@wolf31o2 wolf31o2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, create a test case and guard against the case mentioned by the GitHub code scanner (or an issue for a later PR is fine, too)

cbor/value.go Show resolved Hide resolved
@agaffney agaffney merged commit cf43d34 into main Jul 1, 2023
7 checks passed
@agaffney agaffney deleted the feat/cbor-value-structure branch July 1, 2023 00:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wolf31o2 wolf31o2 wolf31o2 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

extend cbor.Value to store structure info of CBOR value
2 participants
@agaffney @wolf31o2