Create new package for TallyHo name change to Taho #1542
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
@Adamj1232 I think they may want the package name to change? 🤔 Should we double check? It would be simple enough I suppose and then on the old tallyho package we could show it is deprecated? Or even use this? |
@taylorjdawson Yeah that is a good question and we discussed it yesterday in the planning meeting. Im waiting to hear back from the Tally/Taho team on this so we will see what their response is. Their initial request was to just update the displayed wallet name, but its prob best to create a new package and deprecate Tally |
Adamj1232
changed the title
lnbc1QWFyb24
approved these changes
Mar 6, 2023
leightkt
approved these changes
Mar 6, 2023
hlopes-ledger
pushed a commit
to hlopes-ledger/web3-onboard
that referenced
this pull request
Mar 10, 2023
* Rename TallyHo wallet name to Taho * Remove commented out code * Remove unneeded file * Refine deploy script * Revert docs changes * Update more docs * Add Taho docs and fix connect wallet button issue
This was referenced Mar 13, 2023
Merged
Merged
Adamj1232
added a commit
that referenced
this pull request
Mar 14, 2023
* yarn latest packages * Temporarily remove infinity wallet * Fix/sitemap (#1565) * update root path * Update the sitemap generation * Create new package for TallyHo name change to Taho (#1542) * Rename TallyHo wallet name to Taho * Remove commented out code * Remove unneeded file * Refine deploy script * Revert docs changes * Update more docs * Add Taho docs and fix connect wallet button issue * [core, react, vue]: Fix - Remove wallet from localStorage when disconnect is called with the primary wallet label (#1566) * Add removal of localstorage wallet string on disconnect * Add check to confirm the disconnected wallet is also the primary/current wallet * Revert demo change * Fix sitemap (#1573) * SvelteKit+Vite - Fix config issue with sveltekit and vite config - Add docs (#1569) * Fix config issue with sveltekit and vite config * Update package.json * Add examples to docs * Fix funk formatting * Add more notes around sveltekit+vite config and pnpm usage * [walletconnect-v2.3.1-alpha.1]: Update - walletConnect params to include `requiredChains` and updated WC deps (#1574) * Update wc package to the latest and parameterize required chains * Update WC module to allow req chains as parameter * Update docs * Update docs * Update package versions * Fix wc package versioning (#1581) --------- Co-authored-by: Aaron <abarnard@protonmail.com> Co-authored-by: Taylor Dawson <taylorjdawson@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The rename request
TallyHo->Tahocame from the Tally team on a rebrand that has occurredUpdated wallet name, docs and readme-s to make note of this (I don't think creating a new package is justified at this point and would be confusing and a pain for DApps who currently support Tally/Taho)
Request from Taho team:
Checklist
package.jsonof the package you have made changes in is incremented following semantic versioning and using alpha release taggingyarn file-check,yarn type-check&yarn buildto confirm there are not any associated errors