update favicon on docs site #1611
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
This does seem to fix the issue but I feel we are missing the sveltekit way for loading our favicon. The fact that we are getting a 404 on page load makes me think we are missing a config for static files. Maybe something here? |
|
@Adamj1232 I was able to get it to load the existing favicon file by changing the path to |
Adamj1232
added a commit
that referenced
this pull request
Apr 4, 2023
* Yarn docs * update favicon on docs site (#1611) * Update Notify section on the docs site and within readme (#1612) * Update notify docs on docs site and within readme * Update notify api docs * Add screenshots * Update signup link * Remove export from types in docs * Update Docs Favicon to Url (#1618) * Fix broken link in docs (#1616) * Add Kat to GH issue and notion card generation + Fix doc prop name for connect property (#1593) * Yarn the docs * Fix doc prop name for connect property * Add new notion Flag * Add Kat to gh issue notion cards * Update Broken Links on Docs Pages (#1619) * Update WalletConnect `eth_RequestAccounts` flow along with update WC deps and add new optional params (#1622) * Update WC packages * Add logs for testing * Refactor eth_requestAccounts flow * Why Don't I See My Wallet Link (#1617) * Add peer dep required to run package outside of walletconnect eco (#1623) * Update versions for release * Bump versions --------- Co-authored-by: Kat Leight <33187102+leightkt@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update favicon on docs site