Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Joi to latest version and update typing of Joi validate #1633

Merged
merged 4 commits into from
Apr 6, 2023

Conversation

Adamj1232
Copy link
Member

@Adamj1232 Adamj1232 commented Apr 6, 2023

Description

Closes: #1629

Joi issue: hapijs/joi#2917

Updated all packages to use the latest Joi version(17.8.1 -> 17.9.1) which includes a fix for the error Cannot find module '@hapi/hoek/assert' from 'index.js'
Updated typing on validate function

Checklist

  • Increment the version field in package.json of the package you have made changes in following semantic versioning and using alpha release tagging
  • Check the box that allows repo maintainers to update this PR
  • Test locally to make sure this feature/fix works
  • Run yarn check-all to confirm there are not any associated errors
  • Confirm this PR passes Circle CI checks
  • Add or update relevant information in the documentation

@vercel
Copy link

vercel bot commented Apr 6, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
web3-onboard-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 6, 2023 7:33pm

@Adamj1232 Adamj1232 merged commit e92a323 into develop Apr 6, 2023
@Adamj1232 Adamj1232 deleted the fix/joi_import_issue branch April 6, 2023 20:28
Adamj1232 added a commit that referenced this pull request Apr 7, 2023
* Add styling to hidescrollbar across browsers (#1628)

* Bump Joi to latest version and update typing of Joi validate (#1633)

* Bump joi to latest version and update usage

* Revert change to ens validation

* Prettier magic validation

* Prettier uauth validation

* Bump versions for release

* Yarn docs to latest alphas
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Cannot find module '@hapi/hoek/assert' - when running tests
2 participants