Fix: WalletConnect v1 Switch Accounts and bump V2 package support #1644
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
leightkt
approved these changes
Apr 17, 2023
This was referenced Apr 20, 2023
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #1640
The was previously a bug in handling switching of accounts along with a bug within walletConnect that didn't return a standard address case(causing inconsistencies of accounts listed per WalletConnect wallet account).
To test checkout changes and connect MetaMask to WalletConnect V1, then switch accounts back and forth. This should switch seamlessly and the UI/AccountCenter now updates as expected as does the wallets array returned from the demo.
The addresses also match the address if you are to connect MetaMask directly so the address exposed through WalletConnect (bridging MetaMask) and MetaMask directly will match cases.
Checklist
package.jsonof the package you have made changes in following semantic versioning and using alpha release taggingyarn check-allto confirm there are not any associated errors