Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update: WalletConnect - v1 deprecation + additional init options #1795

Merged
merged 6 commits into from
Jun 28, 2023

Conversation

Adamj1232
Copy link
Member

@Adamj1232 Adamj1232 commented Jun 28, 2023

Description

This update includes:

  • Marking WalletConnect V1 as deprecated and defaulting to WC V2
  • Update to latest walletconnect deps
  • Removing the V1 bridge url defaulting to the WC bridge as WC has removed support for this bridge
  • Adding optionalChains as init prop if wanting to override the W3O init chains as the optional chains
  • Adding additionalOptionalMethods to add further methods outside of the default methods defined
  • Update Docs around this change
  • An update to the Core package to fix a console warning around a mislabeled i18n default value

Checklist

  • Increment the version field in package.json of the package you have made changes in following semantic versioning and using alpha release tagging
  • Check the box that allows repo maintainers to update this PR
  • Test locally to make sure this feature/fix works
  • Run yarn check-all to confirm there are not any associated errors
  • Confirm this PR passes Circle CI checks
  • Add or update relevant information in the documentation

@vercel
Copy link

vercel bot commented Jun 28, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
web3-onboard-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 28, 2023 6:53pm

@socket-security
Copy link

New dependencies detected. Learn more about Socket for GitHub ↗︎

Packages Version New capabilities Transitives Size Publisher
@web3-onboard/core 2.20.2-alpha.1 None +0 654 kB cmeisl
@web3-onboard/core 2.19.2 None +0 661 kB cmeisl
@walletconnect/modal 2.5.5 None +4 1.21 MB iljadoesdev

packages/walletconnect/README.md Outdated Show resolved Hide resolved
* Custom URL Bridge must be defined for V1 usage.
* WalletConnect no longer supports a v1 bridge.
* Upgrading to use WalletConnect v2 is recommended.
* A potential bridge can be found here: 'https://derelay.rabby.io'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We would prefer not to endorse this bridge, but we will leave the decision up to your team regarding whether to keep it here.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@finessevanes are there any alternative bridges you would endorse as a possible holdover for projects who may not be in a state to update to V2 currently?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will not be long running (2 months max) and will be removed when V1 code is removed completely

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We will leave here for now but will remove in the coming month when we remove V1 code completely

Adamj1232 and others added 2 commits June 28, 2023 12:06
Co-authored-by: vanes <vanessa.mercado24@gmail.com>
Co-authored-by: vanes <vanessa.mercado24@gmail.com>
@Adamj1232 Adamj1232 merged commit dcf2f7d into develop Jun 28, 2023
3 checks passed
@Adamj1232 Adamj1232 deleted the walletconnect/v1_deprecation branch June 28, 2023 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants