-
Notifications
You must be signed in to change notification settings - Fork 494
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update: WalletConnect - v1 deprecation + additional init options #1795
Conversation
…small fix in core to handle console warn for missing i18n option
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
New dependencies detected. Learn more about Socket for GitHub ↗︎
|
docs/src/routes/docs/[...4]wallets/[...24]walletconnect/+page.md
Outdated
Show resolved
Hide resolved
* Custom URL Bridge must be defined for V1 usage. | ||
* WalletConnect no longer supports a v1 bridge. | ||
* Upgrading to use WalletConnect v2 is recommended. | ||
* A potential bridge can be found here: 'https://derelay.rabby.io' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We would prefer not to endorse this bridge, but we will leave the decision up to your team regarding whether to keep it here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@finessevanes are there any alternative bridges you would endorse as a possible holdover for projects who may not be in a state to update to V2 currently?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will not be long running (2 months max) and will be removed when V1 code is removed completely
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We will leave here for now but will remove in the coming month when we remove V1 code completely
Co-authored-by: vanes <vanessa.mercado24@gmail.com>
Co-authored-by: vanes <vanessa.mercado24@gmail.com>
Description
This update includes:
optionalChains
as init prop if wanting to override the W3O init chains as the optional chainsadditionalOptionalMethods
to add further methods outside of the default methods definedChecklist
package.json
of the package you have made changes in following semantic versioning and using alpha release taggingyarn check-all
to confirm there are not any associated errors