Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Ledger Walletconnect v2 handling and build #1797

Merged
merged 6 commits into from
Jun 28, 2023

Conversation

Adamj1232
Copy link
Member

Description

Fix import breaking build
Remove log from WalletConnect package

@vercel
Copy link

vercel bot commented Jun 28, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
web3-onboard-docs ❌ Failed (Inspect) Jun 28, 2023 7:53pm

@leightkt
Copy link
Contributor

@Adamj1232 do we need to update the ledger module in the docs with our project id as well?

@Adamj1232
Copy link
Member Author

@Adamj1232 do we need to update the ledger module in the docs with our project id as well?

Ah good catch!1!

Co-authored-by: Kat Leight <33187102+leightkt@users.noreply.github.com>
@Adamj1232 Adamj1232 merged commit 1d9b1d5 into develop Jun 28, 2023
3 checks passed
@Adamj1232 Adamj1232 deleted the fix/ledger_WCv2_build branch June 28, 2023 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants