-
Notifications
You must be signed in to change notification settings - Fork 494
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update arcana package and yarn #1858
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adamj1232
reviewed
Aug 2, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Just need full file extensions within the import paths in the index.js and any other files within this module that have imports...looks like just icon import
Adamj1232
approved these changes
Aug 2, 2023
andyogaga
pushed a commit
to andyogaga/web3-onboard
that referenced
this pull request
Aug 3, 2023
* update arcana package and yarn * fix spacing in config * try update spacing * reset spacing on config * update ci branch for test * add ts-ignore * reset config to develop * add file extension to icon --------- Co-authored-by: Adam Carpenter <adamcarpenter86@gmail.com>
leightkt
added a commit
that referenced
this pull request
Aug 3, 2023
* Arcana Auth SDK support (#1744) * Fix: Aracana Config (#1857) * add steps * build staging steps * update arcana package and yarn (#1858) * update arcana package and yarn * fix spacing in config * try update spacing * reset spacing on config * update ci branch for test * add ts-ignore * reset config to develop * add file extension to icon --------- Co-authored-by: Adam Carpenter <adamcarpenter86@gmail.com> * Update Arcana Auth SDK version (#1860) * update arcana/demo packages and root version * add ts-ignore for arcana * Feat: Add native Base chain support and to all quickstarts (#1859) * Add Base chain to all quickstarts * Bump core package in demo * update core, react, vue versions --------- Co-authored-by: Adam Carpenter <adamcarpenter86@gmail.com> Co-authored-by: mmjee <root@git.maharshi.ninja>
leightkt
added a commit
that referenced
this pull request
Aug 3, 2023
* Arcana Auth SDK support (#1744) * Fix: Aracana Config (#1857) * add steps * build staging steps * update arcana package and yarn (#1858) * update arcana package and yarn * fix spacing in config * try update spacing * reset spacing on config * update ci branch for test * add ts-ignore * reset config to develop * add file extension to icon --------- Co-authored-by: Adam Carpenter <adamcarpenter86@gmail.com> * Update Arcana Auth SDK version (#1860) * update arcana/demo packages and root version * add ts-ignore for arcana * Feat: Add native Base chain support and to all quickstarts (#1859) * Add Base chain to all quickstarts * Bump core package in demo * update core, react, vue versions --------- Co-authored-by: Adam Carpenter <adamcarpenter86@gmail.com> Co-authored-by: mmjee <root@git.maharshi.ninja>
Adamj1232
added a commit
that referenced
this pull request
Aug 3, 2023
* Arcana Auth SDK support (#1744) * Fix: Aracana Config (#1857) * add steps * build staging steps * update arcana package and yarn (#1858) * update arcana package and yarn * fix spacing in config * try update spacing * reset spacing on config * update ci branch for test * add ts-ignore * reset config to develop * add file extension to icon --------- Co-authored-by: Adam Carpenter <adamcarpenter86@gmail.com> * Update Arcana Auth SDK version (#1860) * Feat: Add native Base chain support and to all quickstarts (#1859) * Add Base chain to all quickstarts * Bump core package in demo * Release 2.24.7 (develop) (#1863) * update arcana/demo packages and root version * add ts-ignore for arcana * update core, react, vue versions --------- Co-authored-by: Adam Carpenter <adamcarpenter86@gmail.com> * Bump WC deps to the latest (#1866) * Update docs for Base main (#1868) --------- Co-authored-by: mmjee <root@git.maharshi.ninja> Co-authored-by: Kat Leight <33187102+leightkt@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix arcana-auth circleci build