Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use new Inter URL font instead of now invalid old one #2003

Closed
wants to merge 1 commit into from

Conversation

ghivert
Copy link

@ghivert ghivert commented Nov 20, 2023

Description

Because of the change of https://rsms.me few hours ago, old Inter font files URL are now returning a 404 error. This PR uses the new font file URL for the Inter, in order to get the old behavior working.
This is especially important because if a web-app is using Web3-Onboard and Inter in it's files, there's chances that the Inter version of Web3-Onboard will take precedence over the font file loaded by the app.

This should also includes a new release after the merge.

Important to note, there's no changes in the demo, everything is working great. No need to add a screenshot, because there's actually no differences at all.

PLEASE NOTE- Checklist must be complete prior to review.

Checklist

  • Increment the version field in package.json of the package you have made changes in following semantic versioning and using alpha release tagging
  • Check the box that allows repo maintainers to update this PR
  • Test locally to make sure this feature/fix works
  • Run yarn check-all to confirm there are not any associated errors
  • Confirm this PR passes Circle CI checks
  • Add or update relevant information in the documentation

Docs Checklist

  • Include a screenshot of any changes (see docs README on running locally)
  • Add/update the appropriate package README (if applicable)
  • Add/update the related module in the docs demo (if applicable)
  • Add/update the related package in the docs/package.json file (if applicable)

If this PR includes changes to add an injected wallet or SDK wallet module:

Please complete the following using the internal demo package.
To run this demo use the command yarn && yarn dev to get the project running at http://localhost:8080/

Tests with demo app (injected)

  • send transaction
  • switch chains
  • sign message
  • sign typed message
  • disconnect

Tests with demo app (SDK)

  • send transaction
  • switch chains
  • sign message
  • sign typed message
  • disconnect

Signed-off-by: Guillaume Hivert <hivert.is.coming@gmail.com>
@RronKurtishi
Copy link

What's the status with this fix?

@lomocc
Copy link

lomocc commented Jan 4, 2024

As a library, the font selection should be given to the user. There is no need for automatic remote loading.Not to mention that this file address is no longer valid.

@Adamj1232
Copy link
Member

Working on this update and should be available for alpha shortly.
@lomocc font selection is in the hands of the external developers, please see code section here

@Adamj1232
Copy link
Member

Closing in favor of #2092
Thank you for opening this PR!

@Adamj1232 Adamj1232 closed this Mar 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants