Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gnosis: add pilot.gnosisguild.org to default whitelisted domains #2151

Merged
merged 3 commits into from
Apr 12, 2024

Conversation

jfschwarz
Copy link
Contributor

Description

Zodiac Pilot is a browser extension for Safe power users that allows connecting to apps using an EIP-1193 injected provider or through the Safe Apps SDK. In the latter case, there are connection issues in apps using onboard (such as curve.fi) due to the allowedDomains filtering onboard applies by default.

This change adds https://pilot.gnosisguild.org to the default whitelist.

PLEASE NOTE- Checklist must be complete prior to review.

Checklist

  • Increment the version field in package.json of the package you have made changes in following semantic versioning and using alpha release tagging
  • Check the box that allows repo maintainers to update this PR
  • Test locally to make sure this feature/fix works
  • Run yarn check-all to confirm there are not any associated errors
  • Confirm this PR passes Circle CI checks
  • Add or update relevant information in the documentation

Copy link

socket-security bot commented Apr 12, 2024

No dependency changes detected. Learn more about Socket for GitHub ↗︎

👍 No dependency changes detected in pull request

Copy link
Member

@Adamj1232 Adamj1232 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @jfschwarz!

@Adamj1232 Adamj1232 merged commit 6383cd5 into blocknative:develop Apr 12, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants