Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proxy contracts: methods decoding using implementation ABI #3153

Merged
merged 4 commits into from
Jun 17, 2020

Conversation

vbaranov
Copy link
Member

@vbaranov vbaranov commented Jun 16, 2020

#1151 #2839

Motivation

Methods of implementation contract which called on proxy contract are not decoded

Changelog

If contract's ABI contains "implementation" method and it returns an address of existing on-chain contract Blokcscout will retrieve ABI of implementation from its DB (thus, implementation contract should anyways be verified in the Blockscout) and will try to decode methods using full ABI which comprises from proxy and implementations ABIs.

Checklist for your Pull Request (PR)

@vbaranov vbaranov self-assigned this Jun 16, 2020
@vbaranov vbaranov changed the title Proxy contracts: decoding using implementation ABI Proxy contracts: methods decoding using implementation ABI Jun 16, 2020
@vbaranov vbaranov force-pushed the vb-decoding-using-implementation-abi branch from 73c9bb9 to 2900e22 Compare June 16, 2020 13:36
@coveralls
Copy link

coveralls commented Jun 16, 2020

Pull Request Test Coverage Report for Build 04aa3579-37be-48af-9dbb-367da204b66b

  • 17 of 18 (94.44%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.08%) to 74.955%

Changes Missing Coverage Covered Lines Changed/Added Lines %
apps/explorer/lib/explorer/chain/transaction.ex 3 4 75.0%
Totals Coverage Status
Change from base Build 83d526b1-6a67-4965-847d-d1ae67d2e535: 0.08%
Covered Lines: 5869
Relevant Lines: 7830

💛 - Coveralls

@vbaranov vbaranov force-pushed the vb-decoding-using-implementation-abi branch from 2900e22 to 9f5b1cd Compare June 16, 2020 15:38
@vbaranov vbaranov force-pushed the vb-decoding-using-implementation-abi branch from 9f5b1cd to a801cfa Compare June 16, 2020 15:43
@vbaranov vbaranov force-pushed the vb-decoding-using-implementation-abi branch from e42cefe to 485a262 Compare June 17, 2020 10:12
@vbaranov vbaranov force-pushed the vb-decoding-using-implementation-abi branch 3 times, most recently from 33f61bf to 0a33821 Compare June 17, 2020 13:05
@vbaranov vbaranov force-pushed the vb-decoding-using-implementation-abi branch from 0a33821 to ffa8d3c Compare June 17, 2020 13:06
@vbaranov vbaranov merged commit 003389e into master Jun 17, 2020
@vbaranov vbaranov deleted the vb-decoding-using-implementation-abi branch June 17, 2020 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants